Add check for xbmc.python version #103

mzfr · 2018-08-05T17:31:42Z

This will check for the version of xbmc.python in addon.xml file according to the kodi version

kodi_addon_checker/check_dependencies.py

    for required_addon, required_version in deps.items():
        if required_addon not in repo_addons:
            if required_addon not in ignore:
                report.add(Record(
                    PROBLEM, "Required addon %s not available in current repository." % required_addon))
+            elif required_addon == "xbmc.python":


kodi_addon_checker/check_dependencies.py

+            else:
+                version = VERSION_ATTRB[required_addon][branch_name]
+                if not LooseVersion(version) == LooseVersion(required_version):
+                    report.add(Record(WARNING, "You are using and older version xbmc.python"))


kodi_addon_checker/check_dependencies.py

@@ -32,6 +35,12 @@ def check_addon_dependencies(report: Report, repo_addons: dict, parsed_xml, bran
            if required_addon not in ignore:
                report.add(Record(
                    PROBLEM, "Required addon %s not available in current repository." % required_addon))
+            else:
+                version = VERSION_ATTRB[required_addon][branch_name]


kodi_addon_checker/check_dependencies.py

+            else:
+                version = VERSION_ATTRB[required_addon][branch_name]
+                if not LooseVersion(version) == LooseVersion(required_version):
+                    report.add(Record(WARNING, "For %s it is advised to set %s  version to %s" %


kodi_addon_checker/check_dependencies.py

@@ -29,9 +32,15 @@ def check_addon_dependencies(report: Report, repo_addons: dict, parsed_xml, bran

    for required_addon, required_version in deps.items():
        if required_addon not in repo_addons:
-            if required_addon not in ignore:
+            if required_addon not in ignore and required_addon in VERSION_ATTRB:


Rechi · 2018-08-09T08:59:15Z

new feature has to be added in the readme

Rechi · 2018-08-12T08:53:39Z

Update README isn't a descriptive commit message.

Rechi · 2018-08-12T14:49:37Z

First line of the commit message (which you see by git log --oneline or on github in the commit log) still hasn't changed.

As soon as you give it a usefull name it will be similar to ’Add check for xbmc.python version’ and you should ask yourself, why is this a seperate commit.

resolved

kodi_addon_checker/check_dependencies.py

+                    version = VERSION_ATTRB[required_addon][branch_name]
+                    if LooseVersion(version) != LooseVersion(required_version):
+                        report.add(Record(WARNING, "For %s it is advised to set %s version to %s" %
+                                          (branch_name, required_addon, required_version)))


Rechi previously requested changes Aug 5, 2018

View reviewed changes

mzfr force-pushed the xbmc-python-dependency branch from 491ab8a to 112c4b1 Compare August 6, 2018 06:39

enen92 reviewed Aug 6, 2018

View reviewed changes

mzfr force-pushed the xbmc-python-dependency branch from 112c4b1 to 304b240 Compare August 7, 2018 08:22

enen92 approved these changes Aug 7, 2018

View reviewed changes

razzeee reviewed Aug 7, 2018

View reviewed changes

mzfr force-pushed the xbmc-python-dependency branch from 304b240 to 98b2954 Compare August 7, 2018 15:49

razzeee reviewed Aug 7, 2018

View reviewed changes

mzfr force-pushed the xbmc-python-dependency branch from 98b2954 to 54a1ffa Compare August 8, 2018 15:16

mzfr force-pushed the xbmc-python-dependency branch from 54a1ffa to edf713b Compare August 9, 2018 13:42

mzfr force-pushed the xbmc-python-dependency branch from edf713b to b488cdc Compare August 12, 2018 12:54

Add check for xbmc.python version

1382159

mzfr force-pushed the xbmc-python-dependency branch from b488cdc to 1382159 Compare August 12, 2018 15:33

razzeee merged commit d58e9c1 into xbmc:master Aug 12, 2018

Rechi reviewed Aug 20, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add check for xbmc.python version #103

Add check for xbmc.python version #103

mzfr commented Aug 5, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Rechi commented Aug 9, 2018

Rechi commented Aug 12, 2018

Rechi commented Aug 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Add check for xbmc.python version #103

Add check for xbmc.python version #103

Conversation

mzfr commented Aug 5, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Rechi commented Aug 9, 2018

Rechi commented Aug 12, 2018

Rechi commented Aug 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.