Add support for pipenv #99
Conversation
Makefile
Outdated
| pipenv install | ||
|
|
||
| test: | ||
| pipenv run pytest tests/. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| [requires] | ||
| python_version = "3.5" | ||
|
|
||
| [dev-packages] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
.travis.yml
Outdated
| @@ -77,8 +77,7 @@ matrix: | |||
| env: REPO=repo-skins BRANCH=leia | |||
|
|
|||
| # command to install dependencies | |||
| install: | |||
| - pip install -r requirements.txt | |||
| install: "make" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Makefile
Outdated
| pip install pipenv | ||
| pipenv install | ||
|
|
||
| test: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mzfr
force-pushed
the
pipenv
branch
4 times, most recently
from
dd8e324
to
f2fb766
Compare
.travis.yml
Outdated
| @@ -78,7 +78,7 @@ matrix: | |||
|
|
|||
| # command to install dependencies | |||
| install: | |||
| - pip install -r requirements.txt | |||
| - make | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mzfr
force-pushed
the
pipenv
branch
2 times, most recently
from
e66facd
to
fbd007d
Compare
.travis.yml
Outdated
| @@ -87,6 +87,7 @@ before_script: | |||
|
|
|||
| # command to run tests | |||
| script: | |||
| - make test | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -20,7 +17,7 @@ | |||
| url="https://github.com/xbmc/addon-check", | |||
| download_url="https://github.com/xbmc/addon-check/archive/master.zip", | |||
| packages=setuptools.find_packages(exclude=['script.test', 'tests*']), | |||
| install_requires=requirements, | |||
| install_requires=['pillow', 'requests', 'radon'], | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
We shouldn't do that . |
|
If we refer to the author of pipenv, we need to question if it even makes sense for us to switch. pypa/pipenv#1161 (comment) Originally I was thinking we qualify as an application, but due to us distributing via pip it seems like we qualify more in the library sense. |
|
I don't think we want to do this right now, so closing this. |
I have removed the
requirements.txtfile and now anyone can use pipfiles for installing dependencies.Currently there are only three packages i.e (
pillow,radon,requests) present in pipfile.