Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charset problem #38

Closed
masterbug opened this issue Aug 20, 2021 · 10 comments
Closed

Charset problem #38

masterbug opened this issue Aug 20, 2021 · 10 comments

Comments

@masterbug
Copy link

masterbug commented Aug 20, 2021

Hello,

Like this addon. But I have a problem, it does not handle äöü and so on correctly.
The ACC encoder does it right. Maybe you can apply the same charset handling also to the Lame Encoder.
The Filename appears correct, but Kodi displays it wrong. As far as I know this is because of wrong or false charset handling.
Applies to 2.0.x and also to 3.x
regards
Masterbug

@masterbug
Copy link
Author

Here is a picture:
image
And when I display the same in FileExplorer:
001CF864-93CB-4FA0-B6FA-712A9C7829AD

@AlwinEsch
Copy link
Member

Have something about in mind.
I look to fix it, which OS you used about?

@AlwinEsch
Copy link
Member

If you have Windows, OSX or Android, can you take for test purposes a zip from from here and install by you for test?

About company work I'm currently not at home (Hotel room) and not have CD's for test available.

I'm created on #40 an request where becomes the latest liblame added, badly they have on them still no new releases, but if it works, maybe we find a way.

@masterbug
Copy link
Author

masterbug commented Oct 5, 2021

Hello, sorry for the late reply.
it is great to see somebody is looking in this.
I use LibreElec generic for my AllinOne PC. Is there a way to test it with this device?

may I test with Nexus builds?
rgds
Masterbug

@AlwinEsch
Copy link
Member

AlwinEsch commented Oct 5, 2021

A little more difficult, I'll buy a CD tomorrow and test it.
Funnily enough, I'm back for work and home is far away (Saarbrücken at home, and 2 weeks back to work in Frankfurt) 😅 .

Hadn't thought of it at home either.

@masterbug
Copy link
Author

masterbug commented Oct 24, 2021

Hi,
I can also send you a CD of Benjamin Blümchen. This works well to demonstrate its issue.
Greetings
Meanwhile I am on Libreelec 10 with Kodi 19.1 using Lame MP3 Audio Encoder 19.0.0.1 by spiff.

@AlwinEsch
Copy link
Member

Have becomed it fixed now and here a fix request about #44.

The UTF-8 was come in strange format, not only in Kodi, also VLC has shown wrong. The fix sets the string format to UTF-16 and with them it has shown correct.

@AlwinEsch
Copy link
Member

Have brought in the fix requests to Matrix and Nexus version. Hope the libreelec includes soon the update about.

@masterbug
Copy link
Author

This is good to know. Thank you for your work.

@masterbug
Copy link
Author

Hello,
With the release of Libreelec 10.0.2 the fix reached finally my device as well. I can now rip Benjamin Blümchen.
Thank you for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants