[Nexus] fix charset problem on created ID3 tags #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before was the UTF-8 characters not shown correct. This change the set to use UTF-16 strings about where fixes the problem. Related to them is also a new setting value added to select between ID3v1 and ID3v2. On ID3v2 becomes now set the backward in UTF-8 strings and the new about ver. 2 with translated UTF-16 characters. As needed new dependency is now iconv added.
AlwinEsch
force-pushed
the
fix-charset-Nexus
branch
from
79f1bf5
to
b956002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before was the UTF-8 characters not shown correct.
This change the set to use UTF-16 strings about where fixes the problem.
Related to them is also a new setting value added to select between ID3v1 and ID3v2.
On ID3v2 becomes now set the backward in UTF-8 strings and the new about ver. 2 with translated UTF-16 characters.
As needed new dependency is now iconv added.
To fix issue #38