This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Trim down main class and call the correct followup implementation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
reviewed
Jan 27, 2017
| logger.debug("hello addon! %s" % time.time()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
enen92
reviewed
Jan 27, 2017
| addDirectoryItem(plugin.handle, plugin.url_for(show_category, "one"), ListItem("Category One"), True) | ||
| addDirectoryItem(plugin.handle, plugin.url_for(show_category, "two"), ListItem("Category Two"), True) | ||
| addDirectoryItem(plugin.handle, plugin.url_for( | ||
| show_category, "one"), ListItem("Category One"), True) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@enen92 would you be so kind and create issues or even prs for your suggestions? |
|
Sure @razzeee , I'll submit 2 different PR's once this is merged |
|
go for it. I'm sure we'll need several round anyway to get everything "perfect" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to close #11
@MartijnKaijser