Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][DASH] fix live streams not playing, and duration updates. #1201

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

glennguy
Copy link
Contributor

Description

Two changes here:

Motivation and context

Fixes #1152 and unreported issue

How has this been tested?

Tested on Kayo AU add-on. Before - no playback. Before #1178 - no stream duration updates. After both are fixed.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@glennguy glennguy added Type: Fix non-breaking change which fixes an issue v20 Nexus Component: MPEG-DASH labels Mar 30, 2023
@CastagnaIT
Copy link
Collaborator

nexus branch?

@glennguy
Copy link
Contributor Author

Since your PR is very close I thought to not bother with Omega. But I can if you expect it to take a while to review and sort out bugs. I don't mind taking the approach of fixing forward with that one though. I'll let you decide, please say if you think I should PR against Omega too :)

@CastagnaIT
Copy link
Collaborator

CastagnaIT commented Mar 30, 2023

OK then I'll link the PR and i add your changes to my PR, otherwise its difficult tell if it was included in Omega
chenged idea better make separate PR less confusion

Copy link
Collaborator

@CastagnaIT CastagnaIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this has fixed also facebook live regression

@CastagnaIT CastagnaIT changed the title [Nexus][DASH] fix live streams not playing, and duration updates. [backport][DASH] fix live streams not playing, and duration updates. Mar 30, 2023
@CastagnaIT CastagnaIT merged commit b512a14 into xbmc:Nexus Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants