Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled #30161 (greek) #401

Merged
merged 2 commits into from Apr 1, 2020
Merged

Filled #30161 (greek) #401

merged 2 commits into from Apr 1, 2020

Conversation

Twilight0
Copy link

& fill blank strings with the same values to avoid errors on check scripts

& fill blank strings with the same values to avoid errors on check scripts
@Twilight0
Copy link
Author

Sorry for those mistakes in the last PRs, I had rebased my fork on the wrong commit.

@dagwieers
Copy link
Contributor

You don't have to close a PR. If you push your changes to the branch that is tracked by the PR, these updates will automatically be visible in this PR. So simply make the changes, force-push and refresh your page.

@dagwieers
Copy link
Contributor

There is one translation missing at the end. Apparently it was only added to the English translation recently.

@Twilight0
Copy link
Author

Twilight0 commented Mar 18, 2020

There is one translation missing at the end. Apparently it was only added to the English translation recently.

Indeed, just filled it and I reverted that last string to its former translation. I got confused.

@Twilight0 Twilight0 changed the title Better wording for #30160 Filled #30161 (greek) Mar 18, 2020
@peak3d peak3d merged commit 88d7716 into xbmc:master Apr 1, 2020
@Twilight0 Twilight0 deleted the greekstrings branch April 11, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants