Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various translation fixes #402

Merged
merged 2 commits into from Apr 1, 2020
Merged

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Mar 18, 2020

This PR includes:

  • Translations for strings that were expected to be identical
  • Add missing strings to most languages
  • Translate untranslated strings for Dutch
  • Remove BOM from Russian translation
  • Fix syntax errors in French translation
  • Remove unused/incorrect English msgstr entries

@dagwieers
Copy link
Contributor Author

dagwieers commented Mar 18, 2020

@brunoduc @peak3d There seems to be an issue related to the English source to contain a different msgid and msgstr.

Where most translations have translated the msgid (as is custom), the French translation has translated the msgstr instead. This is problematic. I have fixed the English translation file, but we need to re-translate the French translation as well.

This PR includes:
- Translations for strings that were expected to be identical
- Add missing strings to most languages
- Translate untranslated strings for Dutch
- Remove BOM from Russian translation
- Fix syntax errors in French translation
- Remove unused/incorrect English msgstr entries
@dagwieers
Copy link
Contributor Author

dagwieers commented Apr 1, 2020

This one needs to be merged last (after all translations) as it will cause merge conflicts because of untranslated (and missing) strings fixed in those other translation efforts.

@peak3d peak3d merged commit 86c62aa into xbmc:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants