Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdm_adapter: log error if LoadNativeLibrary fails #679

Merged
merged 1 commit into from
May 10, 2021
Merged

cdm_adapter: log error if LoadNativeLibrary fails #679

merged 1 commit into from
May 10, 2021

Conversation

kszaq
Copy link
Contributor

@kszaq kszaq commented May 10, 2021

In case loading libwidevine fails, we should print the reason to log. This simple patch allows to print the error to the debug log.

Related to #678

Copy link
Contributor

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears perfectly sane to me. @glennguy?

@matthuisman
Copy link
Contributor

out of interest, what is the error you get with the latest troublesom Widevine blob?

@kszaq
Copy link
Contributor Author

kszaq commented May 10, 2021

cannot allocate memory in static TLS block
No idea how to fix.

@matthuisman
Copy link
Contributor

matthuisman commented May 10, 2021

quick google I get this:
opencv/opencv#14884
aarch64 issue...

There is no way we are actually getting a new AARCH64 widevine blob are we?
As in - they have finally released one...

Are the Chrome HW they using ARM7 or were they AARCH64 and using ARM7 widevine.
They did just recently do an ARM64 for Mac - so.... maybe ARM64 for Chrome finally?

@glennguy glennguy merged commit 1783ef3 into xbmc:Matrix May 10, 2021
@kszaq kszaq deleted the Matrix-log_widevine_error branch May 10, 2021 21:48
@dagwieers
Copy link
Contributor

Any chance we can return this via the player as an onPlaybackError event as well?

@kszaq
Copy link
Contributor Author

kszaq commented May 11, 2021

I'm afraid no until #497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants