Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ffmpeg configure option for Android #175

Merged
merged 1 commit into from May 19, 2022

Conversation

glennguy
Copy link
Contributor

@glennguy glennguy commented May 1, 2022

Includes the lib path in linker options.
FFMPEG was being given -liconv during the 'check can compile' part of the configure step, the path where iconv libs are placed was not being included.

@glennguy
Copy link
Contributor Author

glennguy commented May 2, 2022

Hi @AlwinEsch
Would you be able to provide some advice? I don't think this is the right solution to the problem but at least shows where the problem is. I think we need to build libiconv as well - no idea why this wasn't an issue before though???

@phunkyfish does this look ok?

@phunkyfish
Copy link
Collaborator

Hi @AlwinEsch Would you be able to provide some advice? I don't think this is the right solution to the problem but at least shows where the problem is. I think we need to build libiconv as well - no idea why this wasn't an issue before though???
@phunkyfish does this look ok?

It makes sense. Let’s see if it builds.

@glennguy
Copy link
Contributor Author

glennguy commented May 5, 2022

Looks good from what I can see, builds fine locally as well.

@phunkyfish
Copy link
Collaborator

Looks good from what I can see, builds fine locally as well.

Looks good from what I can see, builds fine locally as well.

Ah, it’s just the azure builds are broken. Jenkins is good.

Copy link
Collaborator

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the usual version increment and changelog entry and this can be merged and released.

@phunkyfish
Copy link
Collaborator

The commit name should be changed as well. To Fix configure option for android

@phunkyfish phunkyfish changed the title Fix ffmpeg configure option Fix ffmpeg configure option for Android May 19, 2022
@phunkyfish
Copy link
Collaborator

Ok cool. I can force push to your branch. So I fixed the commit message and I'll merge this and fix the Azure builds while I'm at it.

@phunkyfish phunkyfish merged commit 00bc539 into xbmc:Nexus May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants