New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ffmpeg configure option for Android #175
Conversation
21ca8de
to
a3791da
Compare
|
a3791da
to
5aa1a41
Compare
It makes sense. Let’s see if it builds. |
Looks good from what I can see, builds fine locally as well. |
Ah, it’s just the azure builds are broken. Jenkins is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the usual version increment and changelog entry and this can be merged and released.
The commit name should be changed as well. To |
5aa1a41
to
c6de114
Compare
Ok cool. I can force push to your branch. So I fixed the commit message and I'll merge this and fix the Azure builds while I'm at it. |
Includes the lib path in linker options.
FFMPEG was being given -liconv during the 'check can compile' part of the configure step, the path where iconv libs are placed was not being included.