[Omega] Port to FFmpeg 5.1 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
basilgello
commented
Jan 9, 2023
basilgello
commented
- Adapt AlwinEsch's ffmpeg5 port patch
- Fix use-after-free in TimeshiftSegment
- ffmpeg5: Get extradata with extract_extradata BSF
- Separate commit to remove FFmpeg 4 support
- depends: Bump ffmpeg 5.1.2
- Fix build on Windows-UWP-ARM
Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
Fixes the transport stream playback failures described in https://bugs.debian.org/1016925 @Rogo95 made an excellent technical analysis of the root cause and reported that to the bug thread. Later on, James Almer (@jamrial) suggested the solution to use extract_extradata bitstream filter to replace the removed split() function. Finally, I adapted the following code snippet: https://gist.github.com/moonpfe/f6795d51294d91ee0f82f62ff6985db0 to Kodi and tested it by playing the affected files in TS format. Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
Team Kodi does officially support one major FFmpeg version. This commit is intentionally separated to let *nix distro maintainers revert it if building Kodi 20+ is needed with FFmpeg 4. Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
phunkyfish
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.