[windows] Use curl with msys2

[emveepee]

Patch pacman.conf to use curl whichl handles SSL and timeout issues better than pacman. Options used are -k (insecure) -L (follow redirects) and -s (silent) When -s is not used there is curl progress output when the 47 files are downloaded but the filename is still not shown.

[emveepee]

It looks like it passes the azure and jenkins builds. The patch get applied and after the silent curl output the files do get installed.

2020-10-21T13:27:11.4167131Z   Total Download Size:    78.76 MiB
2020-10-21T13:27:11.4167426Z   Total Installed Size:  484.52 MiB
2020-10-21T13:27:11.4168480Z   
2020-10-21T13:27:11.4286166Z   :: Proceed with installation? [Y/n] 
2020-10-21T13:27:11.4286849Z   :: Retrieving packages...
2020-10-21T13:27:43.0235270Z   checking keyring...
2020-10-21T13:27:43.1242111Z   checking package integrity...
2020-10-21T13:27:55.5997508Z   loading package files...
2020-10-21T13:27:56.2369603Z   checking for file conflicts...
2020-10-21T13:27:57.1693053Z   checking available disk space...
2020-10-21T13:27:57.2111419Z   :: Processing package changes...
2020-10-21T13:27:57.2118475Z   installing mingw-w64-cross-binutils...
2020-10-21T13:27:58.3967888Z   installing mingw-w64-x86_64-libiconv...
2020-10-21T13:27:58.5130126Z   installing mingw-w64-x86_64-gmp...
2020-10-21T13:27:58.5823347Z   installing mingw-w64-x86_64-libwinpthread-git...
....

[emveepee]

It still doesn't handle all the cases for users.

6>  0     0    0     0    0     0      0      0 --:--:--  0:02:29 --:--:--     0curl: (7) Failed to connect to ftp.halifax.rwth-aachen.de port 443: Connection timed out

another server is 

6>curl : (22) The requested URL returned error : 403 Forbidden

Maybe the issue is reliable mirrors.

[phunkyfish]

Reliability of mirrors is definitely a factor.

[phunkyfish]

Have you tried adding --retry 10? This may mean a different mirror gets selected.

[emveepee]

Have you tried adding --retry 10? This may mean a different mirror gets selected.

I could add that but I keep ending up back at http://ftp.halifax.rwth-aachen.de/ which currently reports it is having problems. At least I've been able to figure out a patch to use local files and another patch to use manually specified mirrors.

[phunkyfish]

Do you think we could blacklist that one mirror and then make that the default?

The main issue with this being unreliable is for release builds. It's very annoying when users complain that the add-on is not available. The less than happens the better.

[emveepee]

Do you think we could blacklist that one mirror and then make that the default?

The main issue with this being unreliable is for release builds. It's very annoying when users complain that the add-on is not available. The less than happens the better.

I think blacklisting or removing that site until it is back working would be good. It is not clear to me my Kodi ffmpeg builds are not an issue but ffmpegdirect builds fail regularly.

curl may be better but it doesn't give as much output in the build logs

[wsnipex]

http://ftp.halifax.rwth-aachen.de/ is (the) one of our core mirrors and usually very stable. It was down a couple of days due to a hardware issue, but it's back for a while now.
Are you still seeing issues with it?

edit: blacklisting this mirror is not a proper solution

[phunkyfish]

We used to use the msys2 mirror but they have since stopped serving the older version of msys2 that we require so had to switch to our mirrors. It's not a problem specifically with this mirror it's just we don't deal with unreliable mirrors well. So we need to keep re-running the Jenkins build until we get good results across 7 targets (2 windows Jenkins and 5 azure pipelines).