Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rtmp read pause timer - Inputstream API 2.2.0 #64

Merged
merged 4 commits into from Apr 16, 2020
Merged

Rtmp read pause timer - Inputstream API 2.2.0 #64

merged 4 commits into from Apr 16, 2020

Conversation

phunkyfish
Copy link
Contributor

@phunkyfish phunkyfish commented Apr 14, 2020 •
edited

v3.0.3

  • Remove pause and add read pause detect timer for Inputstream API 2.2.0
  • Add debug logger
  • add build script for mac if using xbmc source dir

Do not merge yet

xbmc/xbmc#17633

@phunkyfish phunkyfish changed the title Rtmp read pause timer - Inputstream 2.2.0 Rtmp read pause timer - Inputstream API 2.2.0 Apr 14, 2020
AlwinEsch
AlwinEsch reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@AlwinEsch AlwinEsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the two little things, it looks good for me and the runtime test under Linux was OK.

src/timer/Timer.h Outdated Show resolved Hide resolved
src/utils/Log.h Outdated Show resolved Hide resolved
@phunkyfish phunkyfish merged commit d4b259f into xbmc:Matrix Apr 16, 2020
@phunkyfish phunkyfish deleted the rtmp-read-pause-timer branch April 16, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlwinEsch AlwinEsch AlwinEsch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phunkyfish @AlwinEsch