Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few minor grammar issues in 20.3 release blog #733

Closed
wants to merge 1 commit into from

Conversation

JohnVeness
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jan 14, 2024

👷 Deploy request for kodi-tv pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a278f5d

@ProfYaffle
Copy link
Contributor

Many thanks for this - clearly, my proof-reading was up (down...) to my usual standards, so I'm happy for the corrections. I could try to argue that some of them were merely stylistic choices, but I'm not sure I'd be on very solid ground...

I've cherry-picked the changes and added them via our CMS, as I suspect merging directly might be problematic.

Feel free to let me know if you spot anything else significant, although going back in time over old posts is probably an exercise in futility.

@ProfYaffle ProfYaffle closed this Jan 14, 2024
@JohnVeness JohnVeness deleted the patch-1 branch January 14, 2024 14:44
@JohnVeness
Copy link
Contributor Author

Thanks. Yes, I agree some of my suggestions were nitpicks and not really important!

What usually happens is that if I notice a definite typo, like the extraneous "they" or the lowercase "if", I go to edit the document, and then I tend to make other suggestions just "while I'm there". I.e. things that I wouldn't have bothered to point out on their own.

I forgot you have the CMS, though. I recall a previous discussion where I had wanted to correct typos on older blogs, but we concluded it wasn't really possible without CMS access :(

Thanks for reimplementing the fixes (and adding more) manually anyway :)

@razzeee
Copy link
Member

razzeee commented Jan 14, 2024

FYI, adding stuff here via PRs should be fine and not give any problems whatsoever. The CMS is just a different way to do exactly this.

@JohnVeness
Copy link
Contributor Author

FYI, adding stuff here via PRs should be fine and not give any problems whatsoever. The CMS is just a different way to do exactly this.

Do changes made via PR get "backported" (probably not the right word, but hopefully you'll get what I mean) to the CMS?

@razzeee
Copy link
Member

razzeee commented Jan 14, 2024

Yes, the CMS will always just load the data from here and show it.

@JohnVeness
Copy link
Contributor Author

Ah that's great, thanks.

@JohnVeness
Copy link
Contributor Author

Related: #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants