Greatly improves addon's ability to successfully parse content with '… #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messy' file/directory names not in kodi-recommended format
|
Cheers. However, Kodi already cleans titles before passing them to scrapers. Any adjustments to that process should be applied to Kodi itself, not implemented in a single scraper. |
|
Thanks. Can you point me to where in the codebase it does that?
Kevin Bowen
***@***.*** ***@***.***>
…On Tue, Mar 8, 2022 at 7:58 PM Ryan Rector ***@***.***> wrote:
Cheers.
However, Kodi already cleans titles before passing them to scrapers. Any
adjustments to that process should be applied to Kodi itself, not
implemented in a single scraper.
—
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFZO3GBJ6BNQU7XHD3LOV3U7AOXFANCNFSM5QHTC3XQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It is configured with advancedsettings.xml, which is introduced to the codebase at AdvancedSettings.cpp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…messy' file/directory names not in kodi-recommended format.
For reference, as a brand new Kodi user, when I pointed it at my pre-existing movie library (entirely unsorted and unstructured), it was able to successfully scan and import fewer than half of my movies. With this patch, it gets almost 100%.
It works by just applying mostly-regex based heuristics to strip non-title/date-related junk from the title/filename it's passed.
Crucially, it only attempts heuristics if it first fails to get a match the ordinary way, so it will have no effect on users who do choose to organize their libraries in Kodi-recommended format.