Support looking up via uniqueIDs (filename identifiers) #205
Conversation
|
Agreed about low benefit for the other identifiers. Where is there error message coming from? That shouldn't happen - we do not want to see an error if things are working as expected. Scrapers can log a debug message if they receive an ID they don't recognize, but not much more than that. |
|
TMDB returns 404 if called with a non-existing id: |
sundermann
force-pushed
the
unique-identifiers
branch
from
e8e1e83
to
d7e1769
Compare
|
It fails silently now for the uniqueIDs lookup showing no error notification but still logging the error |
|
Why log as a warning? This is expected behavior now. Any message that shows up outside of debug will generate more support requests. |
sundermann
force-pushed
the
unique-identifiers
branch
from
d7e1769
to
eb3009a
Compare
sundermann
force-pushed
the
unique-identifiers
branch
from
eb3009a
to
d59f038
Compare
|
Alright, changed it to skip logging as well |
|
Cheers |
Add the needed changes for looking up by unique identifiers required for supporting filename identifiers. The current implementation allows only for
tmdbandimdbidentifiers because no additional call to find by id is done. tmdb does support looking up by Facebook, Instagram, TikTok, Twitter, Wikidata and YouTube but the benefit of those identifiers is questionable. The normal tmdb movie API acceptsimdbidentifiers which is probably the most common identifier besides nativetmdbidentifiers.The implementation does not catch errors which means that if a wrong identifier is supplied in the filename an error message is shown in kodi. It is up to debate if it would be better to catch the exception in case of a unique identifier lookup and fail silently. If a movie could not be looked up, Kodi falls back to the traditional lookup by title and year.