remove external module dependencies #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzeee
reviewed
Oct 5, 2020
addon.xml
Outdated
| @@ -1,15 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <addon id="metadata.themoviedb.org.python" | |||
| name="The Movie Database Python" | |||
| version="1.2.1" | |||
| version="1.2.2" | |||
There was a problem hiding this comment.
I don't think this is a bugfix version :D
There was a problem hiding this comment.
Fair enough. I've always thought of the versioning as major.minor.maintenance and this feels like maintenance. But if 1.3.0 would be better, that's fine with me.
razzeee
reviewed
Oct 5, 2020
changelog.txt
Outdated
| @@ -1,3 +1,8 @@ | |||
| v1.2.2 (2020-10-04) | |||
| - Fix: removed dependencies on requests, tmdbsimple, and trakt modules | |||
There was a problem hiding this comment.
I don't think these should be Fix?
There was a problem hiding this comment.
I was trying to keep the changelog to the same format, and there were only Features and Fixes. Features felt like user facing things, so I used Fixes. Could we just list it as Change?
|
Yes, I think that's sensible
…On Tue, Oct 6, 2020, 00:47 Kyle Johnson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In changelog.txt
<#55 (comment)>
:
> @@ -1,3 +1,8 @@
+v1.2.2 (2020-10-04)
+- Fix: removed dependencies on requests, tmdbsimple, and trakt modules
I was trying to keep the changelog to the same format, and there were only
Features and Fixes. Features felt like user facing things, so I used Fixes.
Could we just list it as Change?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNLEZC7OAHPCQ4WA63FH6DSJJEH3ANCNFSM4SD5CBWQ>
.
|
|
3a42bdf updates the change log and version number. I also added the change log info to the news section of addon.xml |
Closed
tielis
pushed a commit
to tielis/metadata.mytmdb.movies
that referenced
this pull request
Jul 18, 2023
…ion-providers-metadata-tvshows-themoviedb-org-python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bundle of code changes to remove the dependencies on tmdbsimple, trakt, and requests modules. All the external calls are now handled by urllib2 (Python 2) or urllib (Python 3). I tried to minimize the changes to the core of the code, so tmdbapi.py mostly mimics the previous API calls and the changes to traktratings.py, imdbratings.py, and fanarttv.py are all internal. There are two sets of changes to tmdb.py.