Fix compiler error #122
Merged
Fix compiler error #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was:
addon.cpp: In member function ‘virtual bool CPeripheralJoystick::SendEvent(const PERIPHERAL_EVENT*)’:
addon.cpp:146:56: error: no matching function for call to ‘JOYSTICK::CJoystickManager::SendEvent(const PERIPHERAL_EVENT&)’
bHandled = CJoystickManager::Get().SendEvent(*event);
^
In file included from addon.cpp:26:0:
JoystickManager.h:132:10: note: candidate: bool JOYSTICK::CJoystickManager::SendEvent(const kodi::addon::PeripheralEvent&)
bool SendEvent(const kodi::addon::PeripheralEvent& event);
^~~~~~~~~
JoystickManager.h:132:10: note: no known conversion for argument 1 from ‘const PERIPHERAL_EVENT’ to ‘const kodi::addon::PeripheralEvent&’
Warnings were:
In file included from addon.cpp:23:0:
addon.h:29:7: warning: ‘CPeripheralJoystick’ declared with greater visibility than the type of its field ‘CPeripheralJoystick::<anonymous>’ [-Wattributes]
class CPeripheralJoystick
^~~~~~~~~~~~~~~~~~~
addon.h:29:7: warning: ‘CPeripheralJoystick’ declared with greater visibility than its base ‘kodi::addon::CAddonBase’ [-Wattributes]
|
Confirmed build fixed on Window, Linux and OSX. Only remaining warning on OSX is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also fix some compiler warnings