Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error #122

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Fix compiler error #122

merged 3 commits into from
Aug 16, 2017

Conversation

garbear
Copy link
Member

@garbear garbear commented Aug 16, 2017

And also fix some compiler warnings

Error was:

addon.cpp: In member function ‘virtual bool CPeripheralJoystick::SendEvent(const PERIPHERAL_EVENT*)’:
addon.cpp:146:56: error: no matching function for call to ‘JOYSTICK::CJoystickManager::SendEvent(const PERIPHERAL_EVENT&)’
     bHandled = CJoystickManager::Get().SendEvent(*event);
                                                        ^
In file included from addon.cpp:26:0:
JoystickManager.h:132:10: note: candidate: bool JOYSTICK::CJoystickManager::SendEvent(const kodi::addon::PeripheralEvent&)
     bool SendEvent(const kodi::addon::PeripheralEvent& event);
          ^~~~~~~~~
JoystickManager.h:132:10: note:   no known conversion for argument 1 from ‘const PERIPHERAL_EVENT’ to ‘const kodi::addon::PeripheralEvent&’
Warnings were:

In file included from addon.cpp:23:0:
addon.h:29:7: warning: ‘CPeripheralJoystick’ declared with greater visibility than the type of its field ‘CPeripheralJoystick::<anonymous>’ [-Wattributes]
 class CPeripheralJoystick
       ^~~~~~~~~~~~~~~~~~~
addon.h:29:7: warning: ‘CPeripheralJoystick’ declared with greater visibility than its base ‘kodi::addon::CAddonBase’ [-Wattributes]
@garbear
Copy link
Member Author

garbear commented Aug 16, 2017

Confirmed build fixed on Window, Linux and OSX. Only remaining warning on OSX is:

In file included from p8-platform/threads/../os.h:37:
p8-platform/posix/os-types.h:124:11: warning: 
      '__stat64' macro redefined [-Wmacro-redefined]
  #define __stat64 stat
          ^
kodi/../kodi/Filesystem.h:29:13: note: 
      previous definition is here
    #define __stat64 stat64
            ^
1 warning generated.

@garbear garbear merged commit cc14287 into xbmc:master Aug 16, 2017
@garbear garbear deleted the fix-error branch August 16, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant