Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peripheral API] Update to v1.3.5: Wheel and throttle support #133

Merged
merged 1 commit into from Dec 24, 2017

Conversation

garbear
Copy link
Member

@garbear garbear commented Dec 13, 2017

This PR allows wheels and throttles to be mapped in the button mapper.

The buttonmap XML for wheels looks like:

<controller id="game.controller.saturn.arcade.racer">
    <feature name="wheel">
        <left axis="-0" />
        <right axis="+0" />
    </feature>
</controller>

The buttonmap XML for throttles looks like:

<controller id="game.controller.saturn.mission.stick">
    <feature name="throttle">
        <up axis="+3" />
        <down axis="-3" />
    </feature>
</controller>

For xbmc/xbmc#13189.

@Montellese
Copy link
Member

Why does the title mention v1.3.5 but the addon has version v1.4.4? In xbmc/xbmc#13189 it's also 1.3.5. Are there different version numbers in play?

@garbear
Copy link
Member Author

garbear commented Dec 16, 2017

They're out of sync because peripheral.joystick's version is bumped more frequently (every add-on api change, to anchor backported commits, etc). I'll sync the versions when we get closer to the 18 release.

It's not as annoying as game.libretro. We're on v1.0.34, the add-on is 1.0.35, and they've been separated by 0.0.1 for a long time :)

@garbear garbear merged commit 3a93486 into xbmc:master Dec 24, 2017
@garbear garbear deleted the wheel-throttle branch December 24, 2017 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants