Re-enable Guide button on Windows 8/10 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially, this was disabled in an attempt to fix the following crash: INVALID_POINTER_READ_DETOURS_c0000005_XInputUap.dll!XInputCore::XInputManager::_XInputManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-enables the Guide button on Windows 8/10. It was originally disabled in early 2017 in #79 due to the following crash reported by some users:
Now, we have some feature requests for the Guide button to return: https://forum.kodi.tv/showthread.php?tid=339917
So I figure we'll enable it for v21 and watch out for any crashes. If all goes well we can ship the Guide button in v21. If we hear more reports of crashes, we can look into other options.
How has this been tested?
Included in latest 20.2 test builds: https://github.com/garbear/xbmc/releases
Tested on latest master. Guide button works, but only after disabling the following setting:
Start -> Settings -> Gaming -> Xbox Game Bar
Disable "Open Xbox Game Bar using this button on a controller: X"
After that, the Guide button works in Kodi.
However, if Steam is open in the background, then it will be focused. Steam must be exited to not interfere with Kodi. There should be a way to fix this in Steam, however.