[plugin.video.putio] 2.3.0 #2474

cenkalti · 2019-08-05T13:35:11Z

Description

Add support for loading all available subtitles

Checklist:

My code follows the add-on rules and piracy stance of this project.
I have read the CONTRIBUTING document
Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
add-on development wiki page.
Kodi pydocs provide information about the Python API
PEP8 codingstyle which is considered best practice but not mandatory.
This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
Development questions can be asked in the add-on development section on the Kodi forum.
If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

TravisBuddy · 2019-08-05T13:37:18Z

Travis tests have failed

Hey @cenkalti,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on plugin.video.putio
INFO: Created by Put.io Developers
INFO: Addon id matches folder name
failed validating {} with XsdAttributeGroup(['lang']):

Reason: missing required attributes: {'lang'}

Schema:

  <xs:extension xmlns:xs="http://www.w3.org/2001/XMLSchema" base="nonEmptyStringCapped">
    <xs:attribute name="lang" type="langIdentifier" use="required" />
  </xs:extension>

Instance:

  <disclaimer />

Path: /extension/disclaimer

failed validating '' with XsdPatternFacets(['\\s*([^\\s]\\s*)+']):

Reason: value doesn't match any pattern of ['\\s*([^\\s]\\s*)+'].

Schema:

  <xs:pattern xmlns:xs="http://www.w3.org/2001/XMLSchema" value="\s*([^\s]\s*)+" />

Instance:

  <disclaimer />

Path: /extension/disclaimer

failed validating '' with XsdPatternFacets(['\\s*([^\\s]\\s*)+']):

Reason: value doesn't match any pattern of ['\\s*([^\\s]\\s*)+'].

Schema:

  <xs:pattern xmlns:xs="http://www.w3.org/2001/XMLSchema" value="\s*([^\s]\s*)+" />

Instance:

  <disclaimer />

Path: /extension/disclaimer

ERROR: Schema validation failed for the following points: xbmc.addon.metadata 
INFO: Image icon exists
ERROR: Icon.png should be solid. It has transparency.
INFO: Icon dimensions are fine 256x256
INFO: You might want to add a fanart
WARN: Complex entry point. Check: main.py | Counted lines: 131 | Lines allowed: 15
WARN: Complex entry point. Check: service.py | Counted lines: 40 | Lines allowed: 15
INFO: PO files are valid
ERROR: We found 2 problems and 2 warnings, please check the logfile.

TravisBuddy · 2019-08-05T14:05:18Z

Travis tests have failed

Hey @cenkalti,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on plugin.video.putio
INFO: Created by Put.io Developers
INFO: Addon id matches folder name
failed validating '' with XsdPatternFacets(['\\s*([^\\s]\\s*)+']):

Reason: value doesn't match any pattern of ['\\s*([^\\s]\\s*)+'].

Schema:

  <xs:pattern xmlns:xs="http://www.w3.org/2001/XMLSchema" value="\s*([^\s]\s*)+" />

Instance:

  <disclaimer lang="en" />

Path: /extension/disclaimer

failed validating '' with XsdPatternFacets(['\\s*([^\\s]\\s*)+']):

Reason: value doesn't match any pattern of ['\\s*([^\\s]\\s*)+'].

Schema:

  <xs:pattern xmlns:xs="http://www.w3.org/2001/XMLSchema" value="\s*([^\s]\s*)+" />

Instance:

  <disclaimer lang="en" />

Path: /extension/disclaimer

ERROR: Schema validation failed for the following points: xbmc.addon.metadata 
INFO: Image icon exists
INFO: Icon dimensions are fine 256x256
INFO: You might want to add a fanart
WARN: Complex entry point. Check: main.py | Counted lines: 131 | Lines allowed: 15
WARN: Complex entry point. Check: service.py | Counted lines: 40 | Lines allowed: 15
INFO: PO files are valid
ERROR: We found 1 problems and 2 warnings, please check the logfile.

TravisBuddy · 2019-08-05T14:13:33Z

Travis tests were successful

Hey @cenkalti,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

plugin.video.putio/addon.xml

TravisBuddy · 2019-08-05T17:55:35Z

Travis tests have failed

Hey @cenkalti,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/urllib3/connectionpool.py", line 603, in urlopen
    chunked=chunked)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/urllib3/connectionpool.py", line 344, in _make_request
    self._validate_conn(conn)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/urllib3/connectionpool.py", line 843, in _validate_conn
    conn.connect()
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/urllib3/connection.py", line 370, in connect
    ssl_context=context)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/urllib3/util/ssl_.py", line 355, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "/opt/python/3.7.1/lib/python3.7/ssl.py", line 412, in wrap_socket
    session=session
  File "/opt/python/3.7.1/lib/python3.7/ssl.py", line 853, in _create
    self.do_handshake()
  File "/opt/python/3.7.1/lib/python3.7/ssl.py", line 1117, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1051)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/adapters.py", line 449, in send
    timeout=timeout
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/urllib3/connectionpool.py", line 641, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/urllib3/util/retry.py", line 399, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='mirror.its.dal.ca', port=443): Max retries exceeded with url: /xbmc/xbmc/addons/jarvis/addons.xml.gz (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1051)')))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.7.1/bin/kodi-addon-checker", line 10, in <module>
    sys.exit(main())
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/kodi_addon_checker/__main__.py", line 85, in main
    all_repo_addons = check_addon.get_all_repo_addons()
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/kodi_addon_checker/check_addon.py", line 120, in get_all_repo_addons
    repo_addons[branch] = Repository(branch, branch_url)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/kodi_addon_checker/addons/Repository.py", line 23, in __init__
    content = requests.get(path, timeout=(10, 10)).content
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/api.py", line 75, in get
    return request('get', url, params=params, **kwargs)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/api.py", line 60, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/sessions.py", line 668, in send
    history = [resp for resp in gen] if allow_redirects else []
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/sessions.py", line 668, in <listcomp>
    history = [resp for resp in gen] if allow_redirects else []
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/sessions.py", line 247, in resolve_redirects
    **adapter_kwargs
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/adapters.py", line 514, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='mirror.its.dal.ca', port=443): Max retries exceeded with url: /xbmc/xbmc/addons/jarvis/addons.xml.gz (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1051)')))

cenkalti · 2019-08-05T17:58:08Z

@enen92 The exception in build log is unrelated. Is there a way to retrigger Travis build?

TravisBuddy · 2019-08-05T18:08:52Z

Travis tests were successful

Hey @cenkalti,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cenkalti · 2019-08-06T08:32:46Z

Hello @enen92. I can't see the latest version when I want to add putio add-on from the repository. How long does it take the repository to get updated after merge?

Rechi · 2019-08-06T08:50:25Z

@cenkalti this add-on isn't Python 3 compatible. Future updates have to be compatible with Python 3.
Have a look at https://kodi.tv/article/attention-addon-developers-migration-python-3 for more information.

enen92 · 2019-08-06T09:12:45Z

@cenkalti the repository sync script runs twice a day iirc. But rechi knows better.

Rechi · 2019-08-06T09:25:05Z

Repository is synced after 2 hours and 30 minutes, but Kodi only checks the repo every 24 hours.

cenkalti mentioned this pull request Aug 5, 2019

List and load all available subtitles putdotio/putio-kodi#11

Merged

cenkalti force-pushed the helix branch from 1213de9 to f77d953 Compare August 5, 2019 14:03

cenkalti force-pushed the helix branch from f77d953 to d505264 Compare August 5, 2019 14:11

enen92 reviewed Aug 5, 2019

View reviewed changes

plugin.video.putio/addon.xml Outdated Show resolved Hide resolved

[plugin.video.putio] 2.3.0

2a3df57

cenkalti force-pushed the helix branch from d505264 to 2a3df57 Compare August 5, 2019 17:54

enen92 merged commit dcf4cbf into xbmc:helix Aug 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[plugin.video.putio] 2.3.0 #2474

[plugin.video.putio] 2.3.0 #2474

cenkalti commented Aug 5, 2019

TravisBuddy commented Aug 5, 2019

TravisBuddy commented Aug 5, 2019

TravisBuddy commented Aug 5, 2019

TravisBuddy commented Aug 5, 2019

cenkalti commented Aug 5, 2019

TravisBuddy commented Aug 5, 2019

cenkalti commented Aug 6, 2019

Rechi commented Aug 6, 2019

enen92 commented Aug 6, 2019

Rechi commented Aug 6, 2019

[plugin.video.putio] 2.3.0 #2474

[plugin.video.putio] 2.3.0 #2474

Conversation

cenkalti commented Aug 5, 2019

Description

Checklist:

TravisBuddy commented Aug 5, 2019

Travis tests have failed

1st Build

TravisBuddy commented Aug 5, 2019

Travis tests have failed

1st Build

TravisBuddy commented Aug 5, 2019

Travis tests were successful

TravisBuddy commented Aug 5, 2019

Travis tests have failed

1st Build

cenkalti commented Aug 5, 2019

TravisBuddy commented Aug 5, 2019

Travis tests were successful

cenkalti commented Aug 6, 2019

Rechi commented Aug 6, 2019

enen92 commented Aug 6, 2019

Rechi commented Aug 6, 2019