Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.nasa] 2.1.0 #2619

Merged
merged 1 commit into from Dec 17, 2019
Merged

[plugin.video.nasa] 2.1.0 #2619

merged 1 commit into from Dec 17, 2019

Conversation

enenbot
Copy link

@enenbot enenbot commented Dec 5, 2019

Add-on details:

  • General

    • Add-on name: Nasa
    • Add-on ID: plugin.video.nasa
    • Version number: 2.1.0
    • Kodi/repository version: gotham
  • Code location

    • URL:

This video plugin provides access to more than 1800 videos, 8 vodcasts and 4 nasa-tv livestreams[CR]All content is dynamic and should be always up to date.

Description of changes:

  2.1.0 (04.12.2019)
    - update to python3
    - fix live streams
    - use new version of xbmcswift2
    - smaller entrypoint
    - fix languages

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

@enen92 enen92 added the Python3 Migration to python3 label Dec 5, 2019
@enen92
Copy link
Member

enen92 commented Dec 5, 2019

Needs xbmc/repo-scripts#1222

@TravisBuddy

This comment has been minimized.

@TravisBuddy
Copy link

Travis tests have failed

Hey @enenbot,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here
INFO: Checking add-on plugin.video.nasa
INFO: Created by Tristan Fischer (sphere@dersphere.de), enen92
INFO: Addon id matches folder name
ERROR: Version mismatch for required dependency script.module.xbmcswift2, required: 2.5.0, Available: 2.4.0
INFO: Image icon exists
INFO: Icon dimensions are fine 512x512
INFO: Image fanart exists
INFO: Fanart dimensions are fine 1920x1080
INFO: PO files are valid
ERROR: We found 1 problems and 0 warnings, please check the logfile.

@TravisBuddy
Copy link

Travis tests were successful

Hey @enenbot,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@enen92 enen92 merged commit fdb8f62 into xbmc:gotham Dec 17, 2019
@enenbot enenbot deleted the plugin.video.nasa branch December 29, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python3 Migration to python3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants