Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.ytchannels] 0.3.2 #3167

Merged
merged 1 commit into from Oct 20, 2020
Merged

[plugin.video.ytchannels] 0.3.2 #3167

merged 1 commit into from Oct 20, 2020

Conversation

mintsoft
Copy link

Description

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@TravisBuddy
Copy link

Travis tests have failed

Hey @mintsoft,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here
INFO: Checking add-on plugin.video.ytchannels
INFO: Created by natko1412,mintsoft,yeahme49
INFO: Addon id matches folder name
ERROR: plugin.video.ytchannels addon already exists with a lower or equal version: 0.3.1+matrix.1 in matrix branch and the addon has non forward abi compatible dependencies. Users migrating to kodi version matrix won't be able to receive the addon update.
INFO: plugin.video.ytchannels addon also exists in leia branch but with update compatible version: 0.3.1
INFO: Valid XML file found
WARN: Required dependency plugin.video.youtube does not require a minimum version, available: 6.8.5
INFO: Image icon exists
INFO: icon dimensions are fine 256x256
INFO: You might want to add a fanart
INFO: PO files are valid
ERROR: We found 1 problems and 1 warnings, please check the logfile.

@TravisBuddy
Copy link

Travis tests were successful

Hey @mintsoft,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@enen92 enen92 merged commit 81aa01e into xbmc:leia Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants