-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update youtube addon: api keys + Krypton support #367
Conversation
I registered on GitHub. I have upload here the release 5.1.20 with the YT APIs fixed based on the latest release of bromix (5.1.16) |
@Kolifanes the right way is to fork this repo -> https://github.com/xbmc/repo-plugins/fork make your changes and submit those change via a PR like what I done here with your collection. Even though this is gpl v2 code and you can grab ANY published code and submit it, its alway nice to let the authors know (because they may have interest in providing those fixes back to main repo here as I done as a favor to you.. any other way of fixing the addon is inefficient and confusing to everyone. tbh @rasberryrabbit surce code and API keys are now 3 hours old in his repo Ive no idea which are better. As a user, sure would like to see things working but submitted back here in a consistent manner. clearly theres devs out there fixing stuff and they are the ones who should submit their patches. |
Hope i have do everything correct. Thanks for your support un1versal. |
Please don't send fixes here. This is not a development repo. Decide on a new upstream, then send a pr as described in http://kodi.wiki/view/Submitting_Add-ons#Github |
then close this. @tamland you realize of course that bromix deleted his complete source and that its chaos out there's several people fixing the addon and none are upstream (several people are just zip source changers) and none share a single common source. Im fine if you close this, I wont do it of course. Im oK with letting the addon die also. |
@tamland I'm not becoming the new maintainer. This is only a fix for APIs. |
@un1versal you are overreacting and completely missing the point. There are now two open conflicting prs. Please discuss this beforehand and don't bring the chaos here spamming everyone. Then, open a pr that follows the guidelines that I can actually merge. |
Im only doing this PR as a special favor to Kolifanes
see http://forum.kodi.tv/showthread.php?tid=200735&pid=2257011#pid2257011
changes from Kolifanes own API changes plus
http://offshoregit.com/finalmakerr/Fixed%20Addons/plugin.video.youtube-5.1.17.zip
https://github.com/rasberryrabbit/plugin.video.youtube
Im not assuming any responsibility or know anything about python development just passing changes forward for the benefit of the larger community.
@zag was in IRC he read the convo.
IF Im honest this PR should be done by @rasberryrabbit and whoever is maintain the pllugin but there you have it, maybe I picked the wrong person to help.