Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.ytchannels] 0.4.0 #3847

Merged
merged 1 commit into from Feb 6, 2022
Merged

Conversation

mintsoft
Copy link

Description

YouTube Channels, listing and playback 0.4.0

Adding:

-URL encode channel name to support UTF-8 encoding
-Update yt_time function
-Add thumbnail and channel description when searching for new channels to add
-Add option to use Invidious instead of YouTube for playing videos

Checklist:

I believe this to be true, invidious is not a piracy addon, it is a privacy addon and whilst isn't in the main addon repo, it's an optional dependency anyway.

  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

<requires>
<import addon="xbmc.python" version="3.0.0"/>
<import addon="script.module.six" version="1.11.0"/>
<import addon="plugin.video.youtube"/>
<import addon="plugin.video.invidious" optional="true"/>
</requires>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is plugin invidious? We don't have this on our repo..

Copy link
Author

@mintsoft mintsoft Jan 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is this: https://github.com/TheAssassin/kodi-invidious-plugin which uses https://github.com/iv-org/invidious under the hood.

It's essentially a privacy proxy for Youtube, it's an optional feature and the settings are only visible if the plugin is enabled already.

@mintsoft
Copy link
Author

@enen92 any update on this? I did check the rules (https://kodi.wiki/view/Add-on_rules) before merging this change into the plugin and there's nothing in there about not having optional dependencies on non-kodi-repo-addons?

@enen92
Copy link
Member

enen92 commented Jan 22, 2022

Sorry for the delay. I brought this issue to the team and the general consensus was to disallow such behaviour. While the plugin today is innofensive we have no control over it so theres no guarantee it will stay like this in the future. Why not ask the author to submit the add-on to the repo?

@mintsoft
Copy link
Author

Yeah fair enough @enen92 I'll see if we can have that conversation

@mintsoft
Copy link
Author

mintsoft commented Feb 6, 2022

@enen92 I've removed invidious support and dependency from this version as it doesn't look like the invidious guys have much interest/time to get it in the main repo :)

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@enen92 enen92 merged commit 6a0869e into xbmc:matrix Feb 6, 2022
@petterreinholdtsen
Copy link

Note, since #3927 the invidious plugin is in matrix, and since #4363 it is in nexus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants