New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin.video.ytchannels] 0.4.0 #3847
Conversation
plugin.video.ytchannels/addon.xml
Outdated
<requires> | ||
<import addon="xbmc.python" version="3.0.0"/> | ||
<import addon="script.module.six" version="1.11.0"/> | ||
<import addon="plugin.video.youtube"/> | ||
<import addon="plugin.video.invidious" optional="true"/> | ||
</requires> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is plugin invidious? We don't have this on our repo..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is this: https://github.com/TheAssassin/kodi-invidious-plugin which uses https://github.com/iv-org/invidious under the hood.
It's essentially a privacy proxy for Youtube, it's an optional feature and the settings are only visible if the plugin is enabled already.
@enen92 any update on this? I did check the rules (https://kodi.wiki/view/Add-on_rules) before merging this change into the plugin and there's nothing in there about not having optional dependencies on non-kodi-repo-addons? |
Sorry for the delay. I brought this issue to the team and the general consensus was to disallow such behaviour. While the plugin today is innofensive we have no control over it so theres no guarantee it will stay like this in the future. Why not ask the author to submit the add-on to the repo? |
Yeah fair enough @enen92 I'll see if we can have that conversation |
7788318
to
cba7973
Compare
@enen92 I've removed invidious support and dependency from this version as it doesn't look like the invidious guys have much interest/time to get it in the main repo :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
YouTube Channels, listing and playback 0.4.0
Adding:
-URL encode channel name to support UTF-8 encoding
-Update yt_time function
-Add thumbnail and channel description when searching for new channels to add
-Add option to use Invidious instead of YouTube for playing videos
Checklist:
I believe this to be true, invidious is not a piracy addon, it is a privacy addon and whilst isn't in the main addon repo, it's an optional dependency anyway.
Additional information :