Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.youtube] 5.3.5 #771

Merged
merged 1 commit into from
Dec 2, 2016
Merged

[plugin.video.youtube] 5.3.5 #771

merged 1 commit into from
Dec 2, 2016

Conversation

jdf76
Copy link

@jdf76 jdf76 commented Nov 21, 2016

Updating youtube plugin from 5.2.1 to 5.3.4

result.extend(v3.response_to_items(provider, context, json_data))
pass

return result


def _process_disliked_videos(provider, context, re_match):
provider.set_content_type(context, kodion.constants.content_type.EPISODES)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.


def _write_file(self, _file, contents):
self.context.log_debug('Writing subtitle file: %s' % _file)
f = xbmcvfs.File(_file, 'w')

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

return False

def set_addon_enabled(self, addon_id, enabled=True):

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@jdf76 jdf76 changed the title [plugin.video.youtube] 5.3.4 [plugin.video.youtube] 5.3.5 Nov 27, 2016
@phil65
Copy link

phil65 commented Nov 27, 2016

Thx for the adjustments.
If some people are complaining about the viewtype changes, please point them to me. ;)

Updating youtube plugin from 5.2.1 to 5.3.5
@jdf76
Copy link
Author

jdf76 commented Dec 1, 2016 via email

@phil65
Copy link

phil65 commented Dec 1, 2016

Skins need to allow Container.Content(videos) for viewtpes that are appropriate for this kind of media ("videos" should basically used for everything which doesnt fit exactly into one of the other available content types).
I hope that I will find some time to write some explanation text in dev section which container.content types should be used by plug-in authors and which content types should be dealt with by skin authors, because up to now a lot of plug-ins / skins do this wrong and just pick what "looks good" without knowing the other implications of havin a wrong content type, and because our documentation in that aspect is really poor.

I will have another look at estuary again and see if i add some more, in case you were talkin about that one.
Hope that helps. ;)

@MartijnKaijser MartijnKaijser merged commit 23cfe3f into xbmc:helix Dec 2, 2016
@anxdpanic
Copy link
Member

not sure what happened, the current helix branch code and resulting zip do not match this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants