[metadata.themoviedb.org.python] v1.4.2 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Scraper update: logos, search languege, finding movies from other years
razzeee
reviewed
Oct 8, 2021
|
Yes. Corrected. |
razzeee
changed the title
|
Please follow the commit message guidelines the next time. I've changed them for you this time. Thanks |
|
WTF? This was not merged upstream. This scraper should still support Leia, but that got thrown out the window too. |
|
The code should be there (I'm on mobile), but your right, that the version wasn't formally released |
I didn't make that up, half of this code wasn't upstreamed until today, after changes from a code review. xbmc/metadata.themoviedb.org.python#101 It was noticed by others: xbmc/metadata.themoviedb.org.python#104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature: downloading logos from tmdb:
Priority:
Feature: search language option added
This is useful if you have other language than "en". For example I hava "pl" and for movie "My Son 2021" I will get wrong result because the right one has polish translation.
I have added new string but is missing for many language (dont know how to add it fast).
Change: searching movies from differnt years if not found
I have file "Nic Smiesznego 1995" for example. But the movie is from 1996 and will not be found. Now it is tried to find from +/- 1 year and without year if not found.
Checklist: