[script.module.future] 0.17.1

[Freso]

Description

• Update future Python module to 0.17.1. See upstream whatsnew.rst for upstream changes.

The 0.16.0.4 PR changed the upstream package somewhat for case-sensitive platforms. AFAICT those same issues do not affect 0.17.x, so I haven’t attempted at porting any of those alterations over—but I also can’t test on non‐Linux platforms (incl. Android) to verify, so I’d especially appreciate a review from @romanvm. :)

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practise but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

[Freso]

I feel like the given error might be "to be expected"? I don’t know if it actually runs the code or just checks to see if it’s valid Python (2 &) 3 code.

[romanvm]

Do I understand correctly that this just a port of the upstream future package with no changes?

[Freso]

Yep. Straight tar -xzvf future-0.17.1.tar.gz’ing (and moving some directories out of the way). No changes to upstream code.

[romanvm]

Please use my comment.

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

[Freso]

Seems the latest Travis run failed because of a connection error, and I don’t have permissions here to make it re‐run. (Also, is there a way to stop @TravisBuddy from leaving dozens of comments?)

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

[Freso]

Looks like there’s an error in kodi_addon_checker/check_py3_compatibility.py – or at least there’s something that triggers an exception that makes it not report useful output for actually fixing if there’s anything wrong in the PR code.

[romanvm]

@Freso Have you actually tested this in Kodi - both py2 and py3 builds? If yes then it should be merged. Unfortunately, I can't tests it myself at the moment.

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/requests/__init__.py:91: RequestsDependencyWarning: urllib3 (1.25.1) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)
INFO: Checking add-on script.module.future
INFO: Created by Ed Schofield
INFO: Addon id matches folder name
INFO: Valid XML file found
INFO: Reverse dependencies: plugin.image.dumpert, plugin.video.101barz, plugin.video.botchamania, plugin.video.cnet.podcasts, plugin.video.dumpert, plugin.video.gamegurumania, plugin.video.gamekings, plugin.video.gamekings, plugin.video.hak5, plugin.video.ign_com, plugin.video.longnow, plugin.video.nlhardwareinfo, plugin.video.orftvthek, plugin.video.powerunlimited, plugin.video.roosterteeth, plugin.video.specialfeatures, plugin.video.tekthing, plugin.video.tweakers, plugin.video.worldstarhiphop, script.module.pyxbmct, script.service.next-episode, service.subtitles.rvm.addic7ed, weather.gismeteo (23)
INFO: Image icon exists
INFO: Icon dimensions are fine 256x256
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.7.1/bin/kodi-addon-checker", line 10, in <module>
    sys.exit(main())
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/kodi_addon_checker/__main__.py", line 89, in main
    report.add(check_artifact(directory, args, args.branch, all_repo_addons, args.PR))
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/kodi_addon_checker/__main__.py", line 55, in check_artifact
    return check_addon.start(artifact_path, branch_name, all_repo_addons, pr, config)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/kodi_addon_checker/check_addon.py", line 74, in start
    check_py3_compatibility.check_py3_compatibility(addon_report, addon_path, branch_name)
  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/kodi_addon_checker/check_py3_compatibility.py", line 71, in check_py3_compatibility
    rt.refactor([path])
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/refactor.py", line 280, in refactor
    self.refactor_dir(dir_or_file, write, doctests_only)
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/refactor.py", line 300, in refactor_dir
    self.refactor_file(fullname, write, doctests_only)
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/refactor.py", line 335, in refactor_file
    tree = self.refactor_string(input, filename)
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/refactor.py", line 361, in refactor_string
    name, err.__class__.__name__, err)
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/refactor.py", line 358, in refactor_string
    tree = self.driver.parse_string(data)
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/pgen2/driver.py", line 104, in parse_string
    return self.parse_tokens(tokens, debug)
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/pgen2/driver.py", line 72, in parse_tokens
    if p.addtoken(type, value, (prefix, start)):
  File "/opt/python/3.7.1/lib/python3.7/lib2to3/pgen2/parse.py", line 159, in addtoken
    raise ParseError("bad input", type, value, context)
lib2to3.pgen2.parse.ParseError: bad input: type=22, value='=', context=('', (395, 41))

[Freso]

I can’t test on py3 builds, but I’ve been using this in my Kodi 18.1 install without any issues. There’s also nothing in the upstream changelog that suggests any backwards incompatible changes. Is there any specific testing you have in mind?

[TravisBuddy]

Travis Buddy

Hey Frederik “Freso” S. Olesen,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[enen92]

good to go?