[script.simkl] 2.2.0

[ekleop]

Description

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practise but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.

[TravisBuddy]

Travis Buddy

Hey Ichika,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[ekleop]

Hi @Rechi is there an approximate timeline when this will be merged?

[enen92]

the news tag is only available for krypton and later versions

[enen92]

Although I am ok with keeping it in the addon.xml since the tag will be ignored by jarvis

[ekleop]

Doesn't krypton and later versions cannot install the addon? so they will use this tag or am I wrong?

[Rechi]

This add-on can be installed in Krypton and newer versions. Those versions do not have a changelog.txt fallback, so if you want to see a changelog inside Kodi, you have to keep the news tag.

[ekleop]

yeap, that is what I wanted to know. We left it specifically for this. Thanks.

[enen92]

please keep this file out of the submission

[enen92]

Only the yaml file that needs to be removed from the submission. Apart from that, it is good to go.
Sorry for the huge delay reviewing the addon.

[enen92]

@ekleop please also drop all the .po files without translations. There's no point in having those since Kodi will always fallback to the en as the default lang

[TravisBuddy]

Travis Buddy

Hey Ichika,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[ekleop]

ok, I've removed yaml file + all empty language files.Everything should be fine now.

[KarellenX]

@enen92
Could you submit this if all is ok. It has been over 5 weeks since the PR was submitted.

Thanks

[KarellenX]

Thanks @enen92