Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[script.trakt] 3.3.0 #1206

Merged
merged 1 commit into from
Dec 3, 2019
Merged

[script.trakt] 3.3.0 #1206

merged 1 commit into from
Dec 3, 2019

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Nov 17, 2019

Description

Here's the new version for matrix.
Two things happend, I ported to matrix and lunatix did some work on PVR detection.

Diff is here:
trakt/script.trakt@3.2.4...master

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

@TravisBuddy
Copy link

Travis tests were successful

Hey @razzeee,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

enen92
enen92 requested changes Dec 3, 2019
View reviewed changes
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Mostly some files that need to be removed from the submission. Apart from that, great work as usual. Thanks!

script.trakt/.gitignore Outdated Show resolved Hide resolved
script.trakt/.gitlab-ci.yml Outdated Show resolved Hide resolved
script.trakt/.travis.yml Outdated Show resolved Hide resolved
script.trakt/addon.xml Outdated Show resolved Hide resolved
script.trakt/addon.xml Outdated Show resolved Hide resolved
script.trakt/changelog.txt Outdated Show resolved Hide resolved
script.trakt/resources/lib/deviceAuthDialog.py Show resolved Hide resolved
script.trakt/resources/lib/kodiUtilities.py
def setSetting(setting, value):
__addon__.setSetting(setting, str(value))

def getSettingAsBool(setting):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be needed in newer api versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I change that in the next version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

script.trakt/resources/lib/kodilogging.py
if getSettingAsBool('debug'):
try:
xbmc.log(self.format(record), levels[record.levelno])
except UnicodeEncodeError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be needed (matrix is py3 only)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I change that in the next version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

script.trakt/tests/fixtures/compare_shows_batman_episode_to_add.json Outdated Show resolved Hide resolved
@TravisBuddy
Copy link

Travis tests were successful

Hey @razzeee,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @razzeee,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@enen92 enen92 merged commit 4ee7629 into xbmc:matrix Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enen92 enen92 enen92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@razzeee @TravisBuddy @enen92