[service.subtitles.napisy24pl] 3.0.0

[CaTzil]

Description

Add support for Matrix (Python 3)

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practise but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.

[TravisBuddy]

Travis tests have failed

Hey @CaTzil,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on service.subtitles.napisy24pl
INFO: Created by CaTz
INFO: Addon id matches folder name
INFO: Valid XML file found
WARN: http://forum.kodi.tv/showthread.php?tid=193829 redirects to https://forum.kodi.tv/showthread.php?tid=193829
WARN: For matrix it is advised to set xbmc.python version to 3.0.0
INFO: Image icon exists
ERROR: Image icon should be explicitly declared in addon.xml <assets>.
INFO: Icon dimensions are fine 256x256
INFO: You might want to add a fanart
WARN: Complex entry point. Check: service.py | Counted lines: 120 | Lines allowed: 15
INFO: ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py
--- ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py	(original)
+++ ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py	(refactored)
@@ -201,7 +201,7 @@
             title = row.find("div", {"class": "uu_oo_uu"}).get_text().title()
             column2 = row.find("div", {"class": "infoColumn2"})
             column2 = "".join([str(x) for x in column2.contents])
-            column2 = [x.strip() for x in filter(None, column2.split("<br/>"))]
+            column2 = [x.strip() for x in [_f for _f in column2.split("<br/>") if _f]]
             year = column2[0]
             video_file_size = column2[4]
             releases = row.find("div", attrs={"data-releases": True})["data-releases"]
ERROR: Using the old language directory structure, please move to the new one.
ERROR: Invalid PO file ./service.subtitles.napisy24pl/resources/language/English/strings.po: Syntax error on line 15
ERROR: Invalid PO file ./service.subtitles.napisy24pl/resources/language/Polish/strings.po: Syntax error on line 15
ERROR: We found 4 problems and 3 warnings, please check the logfile.

[TravisBuddy]

Travis tests have failed

Hey @CaTzil,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

failed validating '' with XsdPatternFacets(['\\s*([^\\s]\\s*)+']):

Reason: value doesn't match any pattern of ['\\s*([^\\s]\\s*)+'].

Schema:

  <xs:pattern xmlns:xs="http://www.w3.org/2001/XMLSchema" value="\s*([^\s]\s*)+" />

Instance:

  <fanart />

Path: /extension/assets/fanart

failed validating '' with XsdPatternFacets(['\\s*([^\\s]\\s*)+']):

Reason: value doesn't match any pattern of ['\\s*([^\\s]\\s*)+'].

Schema:

  <xs:pattern xmlns:xs="http://www.w3.org/2001/XMLSchema" value="\s*([^\s]\s*)+" />

Instance:

  <banner />

Path: /extension/assets/banner

failed validating '' with XsdPatternFacets(['\\s*([^\\s]\\s*)+']):

Reason: value doesn't match any pattern of ['\\s*([^\\s]\\s*)+'].

Schema:

  <xs:pattern xmlns:xs="http://www.w3.org/2001/XMLSchema" value="\s*([^\s]\s*)+" />

Instance:

  <screenshot />

Path: /extension/assets/screenshot

ERROR: Schema validation failed for the following points: xbmc.addon.metadata 
WARN: http://forum.kodi.tv/showthread.php?tid=193829 redirects to https://forum.kodi.tv/showthread.php?tid=193829
INFO: Image icon exists
INFO: Icon dimensions are fine 256x256
WARN: Empty image tag found for fanart
WARN: Empty image tag found for screenshot
WARN: Complex entry point. Check: service.py | Counted lines: 120 | Lines allowed: 15
INFO: ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py
--- ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py	(original)
+++ ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py	(refactored)
@@ -201,7 +201,7 @@
             title = row.find("div", {"class": "uu_oo_uu"}).get_text().title()
             column2 = row.find("div", {"class": "infoColumn2"})
             column2 = "".join([str(x) for x in column2.contents])
-            column2 = [x.strip() for x in filter(None, column2.split("<br/>"))]
+            column2 = [x.strip() for x in [_f for _f in column2.split("<br/>") if _f]]
             year = column2[0]
             video_file_size = column2[4]
             releases = row.find("div", attrs={"data-releases": True})["data-releases"]
ERROR: Invalid PO file ./service.subtitles.napisy24pl/resources/language/resource.language.pl_pl/strings.po: Syntax error on line 15
ERROR: Invalid PO file ./service.subtitles.napisy24pl/resources/language/resource.language.en_us/strings.po: Syntax error on line 15
ERROR: We found 3 problems and 4 warnings, please check the logfile.

[TravisBuddy]

Travis tests have failed

Hey @CaTzil,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on service.subtitles.napisy24pl
INFO: Created by CaTz
INFO: Addon id matches folder name
INFO: Image icon exists
INFO: Icon dimensions are fine 256x256
INFO: You might want to add a fanart
WARN: Complex entry point. Check: service.py | Counted lines: 120 | Lines allowed: 15
INFO: ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py
--- ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py	(original)
+++ ./service.subtitles.napisy24pl/resources/lib/NapisyUtils.py	(refactored)
@@ -201,7 +201,7 @@
             title = row.find("div", {"class": "uu_oo_uu"}).get_text().title()
             column2 = row.find("div", {"class": "infoColumn2"})
             column2 = "".join([str(x) for x in column2.contents])
-            column2 = [x.strip() for x in filter(None, column2.split("<br/>"))]
+            column2 = [x.strip() for x in [_f for _f in column2.split("<br/>") if _f]]
             year = column2[0]
             video_file_size = column2[4]
             releases = row.find("div", attrs={"data-releases": True})["data-releases"]
ERROR: Invalid PO file ./service.subtitles.napisy24pl/resources/language/resource.language.pl_pl/strings.po: Syntax error on line 15
ERROR: Invalid PO file ./service.subtitles.napisy24pl/resources/language/resource.language.en_us/strings.po: Syntax error on line 15
ERROR: We found 2 problems and 2 warnings, please check the logfile.

[TravisBuddy]

Travis tests were successful

Hey @CaTzil,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.