Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[script.adzapper] 1.0.1 #1856

Merged
merged 1 commit into from Feb 21, 2021
Merged

[script.adzapper] 1.0.1 #1856

merged 1 commit into from Feb 21, 2021

Conversation

popy2k14
Copy link

@popy2k14 popy2k14 commented Feb 20, 2021 •
edited

Description

Update for matrix

Checklist:

  • [X ] My code follows the add-on rules and piracy stance of this project.
  • [X ] I have read the CONTRIBUTING document
  • [X ] Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@popy2k14
Copy link
Author

Could not find out what's going wrong with Travis build. Any hints?

@pkscout
Copy link
Member

pkscout commented Feb 20, 2021 •
edited

Good news and bad news. The good news is I triggered another run of the Travis checks and it worked. The bad news is you have some stuff to work through (see the Travis details link at the bottom of the details page for the failed build for the logs and issues). You've got two road blocks (screenshot too large and XML schema failure) that have to be resolved. I would also recommend you look at the complexity issue of the entry point. Entry points aren't cached, so every time they run they have to be "recompiled" from scratch. Ideally the entry point is just something to import and run a library that has the actual logic.

@popy2k14
Copy link
Author

Fixed the screenshot already locally and can commit it.
Sadly i dont know what the whole XML schema is about.

Can you please help me fixing it?

Thx

enen92
enen92 reviewed Feb 21, 2021
View reviewed changes
script.adzapper/addon.xml Outdated
<description lang="en_GB">Add advertisment skipping to your Kodi system, allowing the user to define a time to switch back to the current channel. During this time the user can switch channel without thinking to switch back manually.</description>
<disclaimer lang="en_GB"></disclaimer>
<platform>all</platform>
<license>GNU GENERAL PUBLIC LICENSE. Version 2, June 1991</license>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPL-2.0-only or GPL-2.0-or-later

enen92
enen92 reviewed Feb 21, 2021
View reviewed changes
script.adzapper/addon.xml Outdated
<extension point="xbmc.addon.metadata">
<summary lang="en_GB">Rezap to current channel after some time (advertisment)</summary>
<description lang="en_GB">Add advertisment skipping to your Kodi system, allowing the user to define a time to switch back to the current channel. During this time the user can switch channel without thinking to switch back manually.</description>
<disclaimer lang="en_GB"></disclaimer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If disclaimer is set you need to provide some text, otherwise just remove from addon.xml

enen92
enen92 reviewed Feb 21, 2021
View reviewed changes
script.adzapper/addon.xml Outdated
<import addon="xbmc.python" version="3.0.0"/>
</requires>
<extension point="xbmc.python.script" library="default.py"/>
<extension point="xbmc.service" library="service.py" start="login"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the start argument

enen92
enen92 reviewed Feb 21, 2021
View reviewed changes
script.adzapper/addon.xml Outdated
<license>GNU GENERAL PUBLIC LICENSE. Version 2, June 1991</license>
<forum>https://forum.kodi.tv/showthread.php?tid=329102</forum>
<website>https://forum.kodi.tv/showthread.php?tid=329102</website>
<email></email>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop if empty

enen92
enen92 reviewed Feb 21, 2021
View reviewed changes
script.adzapper/addon.xml Outdated
<website>https://forum.kodi.tv/showthread.php?tid=329102</website>
<email></email>
<source>https://github.com/popy2k14/repo-scripts/tree/matrix/script.adzapper</source>
<news></news>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop if empty or provide text/content

@popy2k14
Copy link
Author

thx. corrected all and force pushed new PR

enen92
enen92 reviewed Feb 21, 2021
View reviewed changes
script.adzapper/resources/lib/settings.py
@@ -0,0 +1,41 @@
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the .pyc files from the submission. Add pycache to gitignore

enen92
enen92 requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the drop of compiled files it's good to go

@popy2k14
Copy link
Author

Sorry, have copied it from my test kodi installation.
Should now be clean :-)

enen92
enen92 approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@enen92 enen92 merged commit c9dd190 into xbmc:matrix Feb 21, 2021
@popy2k14
Copy link
Author

thx for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enen92 enen92 enen92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@popy2k14 @pkscout @enen92