Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service.subtitles.opensubtitles] v5.0.16 #320

Merged
merged 1 commit into from Dec 2, 2016

Conversation

opensubtitles
Copy link

Description

now we require that users needs to login for using this addon.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [sciprt.foo.bar] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

5.0.16

  • Changed descriptions, icons, fanart... (by opensubtitles)

5.0.15

  • disable anonymous login, users need to register on opensubtitles.org and login in addon settings.

5.0.16
- Changed descriptions, icons, fanart... (by opensubtitles)

5.0.15
- disable anonymous login, users need to register on opensubtitles.org and login in addon settings.
@amet
Copy link
Contributor

amet commented Nov 28, 2016

in case anyone gives a shit, I am ok with @opensubtitles taking over the maintenance of this addon

@razzeee
Copy link
Member

razzeee commented Nov 28, 2016

@amet We do :)
Thanks for letting us know.

@amet
Copy link
Contributor

amet commented Nov 28, 2016

@razzeee :) ... just giving @ronie and @MartijnKaijser hard time ;p

@ronie
Copy link
Member

ronie commented Nov 28, 2016

love you too mate ;-)

@amet
Copy link
Contributor

amet commented Nov 28, 2016

hahah, I knew that would bring you out ;p

@keithah
Copy link
Member

keithah commented Dec 1, 2016

I find unacceptable @amet is a lazy quitter.

@tadly
Copy link
Member

tadly commented Dec 1, 2016

This PR looks good to me.
Can we merge or is there a reason for holding back?

@amet
Copy link
Contributor

amet commented Dec 1, 2016

Hahah, after many years of abuse... it's time to let go :))

@MartijnKaijser MartijnKaijser merged commit bd86ef7 into xbmc:gotham Dec 2, 2016
amet referenced this pull request in amet/service.subtitles.opensubtitles Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants