Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[screensaver.google.earth] 1.0.0 #608

Merged
merged 1 commit into from Oct 5, 2017
Merged

[screensaver.google.earth] 1.0.0 #608

merged 1 commit into from Oct 5, 2017

Conversation

Lunatixz
Copy link

@Lunatixz Lunatixz commented Oct 2, 2017 •
edited

minor update

Description

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

learningit
learningit reviewed Oct 3, 2017
View reviewed changes
screensaver.google.earth/gui.py Outdated
def prepareImages(self, results):
for img in results:
label = '%s, %s'%(img['country'],img['region']) if len(img['region']) > 0 else '%s'%(img['country'])
yield xbmcgui.ListItem(label,thumbnailImage=(img['image']))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Lunatixz
[screensaver.google.earth] 1.0.0
6f6ac88 
minor update

Listitem change
@learningit learningit merged commit 3672475 into xbmc:krypton Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@learningit learningit learningit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lunatixz @learningit