revert ISO support #53
Conversation
|
Probably want to ping @zach-morris As he introduced that change in 1021869 maybe he can give some context into the use case it was intended for |
|
This also needs a version bump and tag in order to be deployed to mirrors. |
|
Version bump is done. Can't do anything for the tags as I don't have the rights for it (and I don't necessarily need them ;) ) |
|
I did not test that, but it seems like a good idea to revert. It would only minorly inconvenience users of retroplayer. Including these two formats supported opening the archive/container and launching the correct files for retroplayer. Eventually, playing ISO games and playing DVD/BRs can hopefully be sorted out. The context of this change, and a different one previously suggested for rar support is for retroplayer. The issue is that some formats (rar, iso being good examples) are historically containerizing videos to play, but with the introduction of retroplayer, many games are containerized in the same formats, so there's a conflict. Kodi can't discern between the two currently i guess. If/when retroplayer becomes more utilized maybe a 'play using' option is the best workaround, or perhaps Kodi can detect what type of media is to be played / what addon to use to open the container in another fashion |
|
I see more and more ppl who have issue while that addon being installed. Is there something which stops this PR to be merged? |
|
Needs someone with commit rights, going to have to find someone on slack to get it in |
|
Agreed this really needs to be merged. |
|
Now this has been merged I assume a PR needs to done to https://github.com/xbmc/repo-binary-addons to push it to the repo? or does it just need a new tag ??? |
|
Nothing else is required. Just the tag. |
Kodi itself has ISO support. So we should probably revert ISO support for this add-on as ppl are complaining that their DVD and BR ISO files aren't played anymore or do behave pretty strange. For example:
xbmc/xbmc#18897
This is a first wild shot to fix that. But as long as there's no other fix (which I'm not able to do because of lacking development skills), this add-on should not conflict with Kodi core functionalities.