Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles are not extracted when they are in a rar inside a rar #34

Closed
amazingdash opened this issue Dec 2, 2018 · 6 comments
Closed
Labels
Bug fixed To define by user or dev that related issue is finally fixed Kodi related To define by dev that fault comes from Kodi itself and mostly not possible to fix on addon Typ: Bug To define by user as the related part not work, but Kodi can still be further used

Comments

@amazingdash
Copy link

Hello, before v18, kodi properly handled subs inside rars inside rars:

INFO: ScanArchiveForAssociatedItems: found associated file rar://****%2fSubs%2fmovie.subs.rar/movie.idx
DEBUG: ScanArchiveForAssociatedItems: Scanning archive rar://****%2fSubs%2fmovie.subs.rar/movie.rar
DEBUG: Thread RarFileExtract start, auto delete: false
DEBUG: Thread RarFileExtract 140642999072512 terminating
INFO: ScanArchiveForAssociatedItems: found associated file rar://rar%3a%2f*****%252fmovie%252fSubs%252fmovie.subs.rar%2fmovie.rar/movie.sub

This does not work with this addon. This is a problem because subtitles are often in a weird format, they are in a RAR file that contains:

  • an IDX file
  • a RAR file that contains the SUB file

With the vfs addon, only the top level IDX file is extracted.

@Sopor
Copy link
Contributor

Sopor commented Nov 26, 2019

For me it will work if i manually load the subs, but it will not auto-load and it doesn't matter if it is STORED or BEST compression.

I'm running Kodi 18.5 on Windows 10 x64 1903

@AlwinEsch
Copy link
Member

The new version is released:

  • 3.3.0-Matrix
  • 2.3.0-Leia

During my tests it was OK, @amazingdash and @Sopor can you confirm?

@Sopor
Copy link
Contributor

Sopor commented Apr 7, 2020

@AlwinEsch I did a test with 2.3.0 and it will still not auto-load the subtitles :(

But i don't know if it has something to do with the empty file name?

image

@AlwinEsch
Copy link
Member

Ah forget that is in Kodi Leia itself. Possible that related with this.
There was this about xbmc/xbmc#17485 which then in Leia 18.7 fixed.

Has tested before with Kodi Matrix where it has worked by me with them.

@amazingdash
Copy link
Author

@AlwinEsch It still doesn't autoload subtitles with 2.3.0. I have built Kodi 18.6 with the backport that you linked.

However, I can now browse for subtitles from the rar in rar and select them, I'm not sure this used to be possible. It's still very annoying because browse doesn't show the current folder.

Can you try with 18.6 (+ the patch you mentioned)? I doubt it will work for you either. If necessary, I can provide you with test files, let me know.

@AlwinEsch AlwinEsch added Kodi related To define by dev that fault comes from Kodi itself and mostly not possible to fix on addon Typ: Bug To define by user as the related part not work, but Kodi can still be further used labels Apr 18, 2020
@AlwinEsch
Copy link
Member

This part is now fixed within Leia and Matrix, after release of Kodi 18.8 is it then available for use.

@AlwinEsch AlwinEsch added the Bug fixed To define by user or dev that related issue is finally fixed label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fixed To define by user or dev that related issue is finally fixed Kodi related To define by dev that fault comes from Kodi itself and mostly not possible to fix on addon Typ: Bug To define by user as the related part not work, but Kodi can still be further used
Projects
None yet
Development

No branches or pull requests

3 participants