Skip to content

Commit

Permalink
Fix VA-API decoding artefacts.
Browse files Browse the repository at this point in the history 
Fixes ffmpeg ticket #457.

Signed-off-by: elupus <elupus@xbmc.org>
  • Loading branch information
@huceke
huceke authored and elupus committed Dec 9, 2011
1 parent ea07d6a commit 1273fc0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/ffmpeg/libavcodec/vaapi_h264.c
View file
Expand Up @@ -280,7 +280,8 @@ static int start_frame(AVCodecContext *avctx,
if (!iq_matrix)
return -1;
memcpy(iq_matrix->ScalingList4x4, h->pps.scaling_matrix4, sizeof(iq_matrix->ScalingList4x4));
memcpy(iq_matrix->ScalingList8x8, h->pps.scaling_matrix8, sizeof(iq_matrix->ScalingList8x8));
memcpy(iq_matrix->ScalingList8x8[0], h->pps.scaling_matrix8[0], sizeof(iq_matrix->ScalingList8x8[0]));
memcpy(iq_matrix->ScalingList8x8[1], h->pps.scaling_matrix8[3], sizeof(iq_matrix->ScalingList8x8[0]));
return 0;
}

Expand Down

5 comments on commit 1273fc0

@huceke
Copy link
Contributor Author

@huceke huceke commented on 1273fc0 Dec 10, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch does not apply to our ffmpeg version. In our version it produces decoding artefacts.

@elupus
Copy link
Contributor

@elupus elupus commented on 1273fc0 Dec 10, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch... Any idea why it doesn't work with our ffmpeg? Does the bug you fixed with the change exist in our code?

@huceke
Copy link
Contributor Author

@huceke huceke commented on 1273fc0 Dec 10, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They introduced the changes at later version than we use.

Also ffmpeg VDPAU needed that update :

http://git.videolan.org/?p=ffmpeg.git;a=commit;h=e747b091cbc6b41f3531cfdf9d1bdd34606b1df3

@elupus
Copy link
Contributor

@elupus elupus commented on 1273fc0 Dec 10, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huceke
Copy link
Contributor Author

@huceke huceke commented on 1273fc0 Dec 10, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Please sign in to comment.