fixed: "|s" passed to PyArg_ParseTuple means the string is an optiona…

…l parameter, so if it's not there the char** is not modified, we need to initialize it to NULL and check if it's set later on
xbmc · Jun 6, 2012 · 1a2e1bd · 1a2e1bd
1 parent 9b7ac43
commit 1a2e1bd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/xbmc/interfaces/python/xbmcmodule/xbmcvfsmodule.cpp b/xbmc/interfaces/python/xbmcmodule/xbmcvfsmodule.cpp
@@ -64,7 +64,7 @@ extern "C" {
     PyObject* File_New(PyTypeObject *type, PyObject *args, PyObject *kwds)
     {
       PyObject *f_line;
-      char *cLine;
+      char *cLine = NULL;
       if (!PyArg_ParseTuple(
                             args,
                             (char*)"O|s",
@@ -82,7 +82,7 @@ extern "C" {
         return NULL;
 
       self->pFile = new CFile();
-      if (strncmp(cLine, "w", 1) == 0)
+      if (cLine && strncmp(cLine, "w", 1) == 0)
       {
         CPyThreadState pyState;
         self->pFile->OpenForWrite(strSource,true);