Skip to content

Commit

Permalink
Fixed: [Confluence] updated the Home screen "Now Playing" media icons…
Browse files Browse the repository at this point in the history 
… to use Player.Art(thumb)
  • Loading branch information
@JezzX
JezzX committed Oct 13, 2012
1 parent d807792 commit 217efbc
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions addons/skin.confluence/720p/Home.xml
View file
Expand Up @@ -40,7 +40,7 @@
<width>130</width>
<height>295</height>
<aspectratio aligny="bottom">keep</aspectratio>
<texture>$INFO[MusicPlayer.Cover]</texture>
<texture fallback="DefaultAlbumCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
Expand Down Expand Up @@ -244,7 +244,7 @@
<width>150</width>
<height>300</height>
<aspectratio aligny="bottom">keep</aspectratio>
<texture>$INFO[VideoPlayer.Cover]</texture>
<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
Expand Down Expand Up @@ -284,7 +284,7 @@
<width>120</width>
<height>300</height>
<aspectratio aligny="bottom">keep</aspectratio>
<texture>$INFO[VideoPlayer.Cover]</texture>
<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
Expand Down Expand Up @@ -337,7 +337,7 @@
<width>120</width>
<height>300</height>
<aspectratio aligny="bottom">keep</aspectratio>
<texture>$INFO[VideoPlayer.Cover]</texture>
<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
Expand Down Expand Up @@ -390,7 +390,7 @@
<width>180</width>
<height>120</height>
<aspectratio>scale</aspectratio>
<texture>$INFO[VideoPlayer.Cover]</texture>
<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
Expand Down

14 comments on commit 217efbc

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change broke the channel icons with PVR. When watching a channel and going to the home screen, it does not show the channel icon, only shows the default 'video' icon.

Same happens on the info screen while watching PVR.

Edit: Channel icons still show fine in the guide and mini guide.

@JezzX
Copy link
Contributor Author

@JezzX JezzX commented on 217efbc Oct 13, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think this was broken before this commit because I did this too try and fix it I think the actual art stuff was the problem to begin with

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... I think it was working on the Oct 11th version back. I can verify that for you if you like.

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize, the last version that the icons were working was this build XBMCSetup-20121010-8756dfb-master (10/10/2012). After that they were not showing correctly.

Thanks JezzX & sorry for the confusion.

@JezzX
Copy link
Contributor Author

@JezzX JezzX commented on 217efbc Oct 13, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah maybe @jmarshallnz might have an idea why since he did all the changes on the backend code

@jmarshallnz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it's because only the icon is set, and perhaps this one doesn't fallback to the icon.

Try reverting 3b6c352

(This isn't a correct fix IMO, but will confirm the root cause)

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarshallnz, do I need to put in a request (or notify someone) to have this change (the 3b6c352 commit) reverted?

Thanks!

@jmarshallnz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you need to test whether that is the problem first.

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way to test. I do not have the XBMC dev environment setup. I have tried in the past, but could never get the dependencies correct to compile... Sorry :(

Im trying again now...

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to build, but still unsuccessful. Can someone create a build with the 3b6c352 commit/patch reverted for me to test?

@jmarshallnz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Billy's doing one for you. It'll pop up in here in a couple hours: http://mirrors.xbmc.org/test-builds/win32/

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I am also in the process of trying to set up the environment on my work development machine. Hopefully I can get it set up so you don't have to go through this in the future.

@xhaggi
Copy link
Member

@xhaggi xhaggi commented on 217efbc Oct 16, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that this commit doesn't breaks the channel icons. i have the same issue in skin aeon nox tested $INFO[VideoPlayer.Cover] and $INFO[Player.Art(thumb)] both aren't working for pvr channel icons.

@wileecoyotejr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarshallnz, I can confirm that the test build Billy provided does fix the channel icons. I tested with Confluence and Aeon Nox. See images below...

http://www.dotnetdevelopers.net/xbmc/images/icon1.png
http://www.dotnetdevelopers.net/xbmc/images/icon2.png
http://www.dotnetdevelopers.net/xbmc/images/icon3.png

Please sign in to comment.