Skip to content
This repository
Browse code

Fixed: [Confluence] updated the Home screen "Now Playing" media icons…

… to use Player.Art(thumb)
  • Loading branch information...
commit 217efbc6480dc77b596a5414528390b1f8aac124 1 parent d807792
Jezz authored October 13, 2012

Showing 1 changed file with 5 additions and 5 deletions. Show diff stats Hide diff stats

  1. 10  addons/skin.confluence/720p/Home.xml
10  addons/skin.confluence/720p/Home.xml
@@ -40,7 +40,7 @@
40 40
 				<width>130</width>
41 41
 				<height>295</height>
42 42
 				<aspectratio aligny="bottom">keep</aspectratio>
43  
-				<texture>$INFO[MusicPlayer.Cover]</texture>
  43
+				<texture fallback="DefaultAlbumCover.png">$INFO[Player.Art(thumb)]</texture>
44 44
 				<bordertexture border="8">ThumbBorder.png</bordertexture>
45 45
 				<bordersize>5</bordersize>
46 46
 			</control>
@@ -244,7 +244,7 @@
244 244
 					<width>150</width>
245 245
 					<height>300</height>
246 246
 					<aspectratio aligny="bottom">keep</aspectratio>
247  
-					<texture>$INFO[VideoPlayer.Cover]</texture>
  247
+					<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
248 248
 					<bordertexture border="8">ThumbBorder.png</bordertexture>
249 249
 					<bordersize>5</bordersize>
250 250
 				</control>
@@ -284,7 +284,7 @@
284 284
 					<width>120</width>
285 285
 					<height>300</height>
286 286
 					<aspectratio aligny="bottom">keep</aspectratio>
287  
-					<texture>$INFO[VideoPlayer.Cover]</texture>
  287
+					<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
288 288
 					<bordertexture border="8">ThumbBorder.png</bordertexture>
289 289
 					<bordersize>5</bordersize>
290 290
 				</control>
@@ -337,7 +337,7 @@
337 337
 					<width>120</width>
338 338
 					<height>300</height>
339 339
 					<aspectratio aligny="bottom">keep</aspectratio>
340  
-					<texture>$INFO[VideoPlayer.Cover]</texture>
  340
+					<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
341 341
 					<bordertexture border="8">ThumbBorder.png</bordertexture>
342 342
 					<bordersize>5</bordersize>
343 343
 				</control>
@@ -390,7 +390,7 @@
390 390
 					<width>180</width>
391 391
 					<height>120</height>
392 392
 					<aspectratio>scale</aspectratio>
393  
-					<texture>$INFO[VideoPlayer.Cover]</texture>
  393
+					<texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
394 394
 					<bordertexture border="8">ThumbBorder.png</bordertexture>
395 395
 					<bordersize>5</bordersize>
396 396
 				</control>

14 notes on commit 217efbc

Charles Metz Jr

I think this change broke the channel icons with PVR. When watching a channel and going to the home screen, it does not show the channel icon, only shows the default 'video' icon.

Same happens on the info screen while watching PVR.

Edit: Channel icons still show fine in the guide and mini guide.

Jezz
Collaborator

I actually think this was broken before this commit because I did this too try and fix it I think the actual art stuff was the problem to begin with

Charles Metz Jr

Hmmm... I think it was working on the Oct 11th version back. I can verify that for you if you like.

Charles Metz Jr

I apologize, the last version that the icons were working was this build XBMCSetup-20121010-8756dfb-master (10/10/2012). After that they were not showing correctly.

Thanks JezzX & sorry for the confusion.

Jezz
Collaborator

yeah maybe @jmarshallnz might have an idea why since he did all the changes on the backend code

jmarshallnz
Owner

I suspect it's because only the icon is set, and perhaps this one doesn't fallback to the icon.

Try reverting 3b6c352

(This isn't a correct fix IMO, but will confirm the root cause)

Charles Metz Jr

@jmarshallnz, do I need to put in a request (or notify someone) to have this change (the 3b6c352 commit) reverted?

Thanks!

jmarshallnz
Owner

No, you need to test whether that is the problem first.

Charles Metz Jr

I have no way to test. I do not have the XBMC dev environment setup. I have tried in the past, but could never get the dependencies correct to compile... Sorry :(

Im trying again now...

Charles Metz Jr

I have tried to build, but still unsuccessful. Can someone create a build with the 3b6c352 commit/patch reverted for me to test?

jmarshallnz
Owner

Billy's doing one for you. It'll pop up in here in a couple hours: http://mirrors.xbmc.org/test-builds/win32/

Charles Metz Jr

Thanks!

I am also in the process of trying to set up the environment on my work development machine. Hopefully I can get it set up so you don't have to go through this in the future.

Sascha Woo
Collaborator

can confirm that this commit doesn't breaks the channel icons. i have the same issue in skin aeon nox tested $INFO[VideoPlayer.Cover] and $INFO[Player.Art(thumb)] both aren't working for pvr channel icons.

Charles Metz Jr

@jmarshallnz, I can confirm that the test build Billy provided does fix the channel icons. I tested with Confluence and Aeon Nox. See images below...

http://www.dotnetdevelopers.net/xbmc/images/icon1.png
http://www.dotnetdevelopers.net/xbmc/images/icon2.png
http://www.dotnetdevelopers.net/xbmc/images/icon3.png

Please sign in to comment.
Something went wrong with that request. Please try again.