Skip to content

Commit

Permalink
fixed, add float to float convert with a copy so we do not have to ch…
Browse files Browse the repository at this point in the history
…eck convertFn for null all over the place
  • Loading branch information
davilla committed Jul 14, 2013
1 parent 647cf55 commit 37b8fb7
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
16 changes: 16 additions & 0 deletions xbmc/cores/AudioEngine/Utils/AEConvert.cpp
Expand Up @@ -95,6 +95,7 @@ CAEConvert::AEConvertToFn CAEConvert::ToFloat(enum AEDataFormat dataFormat)
case AE_FMT_S32LE : return &S32LE_Float;
case AE_FMT_S32BE : return &S32BE_Float;
#endif
case AE_FMT_FLOAT : return &Float_Float;
case AE_FMT_DOUBLE: return &DOUBLE_Float;
default:
return NULL;
Expand Down Expand Up @@ -125,6 +126,7 @@ CAEConvert::AEConvertFrFn CAEConvert::FrFloat(enum AEDataFormat dataFormat)
case AE_FMT_S32LE : return &Float_S32LE;
case AE_FMT_S32BE : return &Float_S32BE;
#endif
case AE_FMT_FLOAT : return &Float_Float;
case AE_FMT_DOUBLE: return &Float_DOUBLE;
default:
return NULL;
Expand Down Expand Up @@ -371,6 +373,13 @@ unsigned int CAEConvert::S32BE_Float_Neon(uint8_t *data, const unsigned int samp
return samples;
}

unsigned int CAEConvert::Float_Float(uint8_t *data, const unsigned int samples, float *dest)
{
memcpy(dest, data, samples*sizeof(float));

return samples;
}

unsigned int CAEConvert::DOUBLE_Float(uint8_t *data, const unsigned int samples, float *dest)
{
double *src = (double*)data;
Expand Down Expand Up @@ -1143,6 +1152,13 @@ unsigned int CAEConvert::Float_S32BE_Neon(float *data, const unsigned int sample
return samples << 2;
}

unsigned int CAEConvert::Float_Float(float *data, const unsigned int samples, uint8_t *dest)
{
memcpy(dest, data, samples*sizeof(float));

return samples;
}

unsigned int CAEConvert::Float_DOUBLE(float *data, const unsigned int samples, uint8_t *dest)
{
double *dst = (double*)dest;
Expand Down
2 changes: 2 additions & 0 deletions xbmc/cores/AudioEngine/Utils/AEConvert.h
Expand Up @@ -34,6 +34,7 @@ class CAEConvert{
static unsigned int S24BE3_Float(uint8_t *data, const unsigned int samples, float *dest);
static unsigned int S32LE_Float (uint8_t *data, const unsigned int samples, float *dest);
static unsigned int S32BE_Float (uint8_t *data, const unsigned int samples, float *dest);
static unsigned int Float_Float (uint8_t *data, const unsigned int samples, float *dest);
static unsigned int DOUBLE_Float(uint8_t *data, const unsigned int samples, float *dest);

static unsigned int Float_U8 (float *data, const unsigned int samples, uint8_t *dest);
Expand All @@ -44,6 +45,7 @@ class CAEConvert{
static unsigned int Float_S24NE3(float *data, const unsigned int samples, uint8_t *dest);
static unsigned int Float_S32LE (float *data, const unsigned int samples, uint8_t *dest);
static unsigned int Float_S32BE (float *data, const unsigned int samples, uint8_t *dest);
static unsigned int Float_Float (float *data, const unsigned int samples, uint8_t *dest);
static unsigned int Float_DOUBLE(float *data, const unsigned int samples, uint8_t *dest);

static unsigned int S32LE_Float_Neon (uint8_t *data, const unsigned int samples, float *dest);
Expand Down

1 comment on commit 37b8fb7

@davilla
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FernetMenta , ActiveAE does a convertFn in GernerateNoise, Android uses float for video so a null gets returned and bang. This fills the hole and does not require external handling if using ae float format in a sink.

Please sign in to comment.