Skip to content

Commit

Permalink
videodb: use strings instead of numbers in videodb:// URL
Browse files Browse the repository at this point in the history
  • Loading branch information
@Montellese
Montellese committed Apr 8, 2013
1 parent e2efdc2 commit 66263ca
Show file tree
Hide file tree
Showing 54 changed files with 274 additions and 275 deletions.
2 changes: 1 addition & 1 deletion system/library/video/movies/actors.xml
View file
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="4" type="folder">
<label>344</label>
<path>videodb://1/4</path>
<path>videodb://movies/actors/</path>
<icon>DefaultActor.png</icon>
</node>

2 changes: 1 addition & 1 deletion system/library/video/movies/country.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="8" type="folder">
<label>20451</label>
<path>videodb://1/8</path>
<path>videodb://movies/countries/</path>
<icon>DefaultCountry.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/movies/directors.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="5" type="folder">
<label>20348</label>
<path>videodb://1/5</path>
<path>videodb://movies/directors/</path>
<icon>DefaultDirector.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/movies/genres.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="1" type="folder">
<label>135</label>
<path>videodb://1/1</path>
<path>videodb://movies/genres/</path>
<icon>DefaultGenre.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/movies/sets.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="7" type="folder" visible="Library.HasContent(MovieSets)">
<label>20434</label>
<path>videodb://1/7</path>
<path>videodb://movies/sets/</path>
<icon>DefaultSets.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/movies/studios.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="6" type="folder">
<label>20388</label>
<path>videodb://1/6</path>
<path>videodb://movies/studios/</path>
<icon>DefaultStudios.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/movies/tags.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="9" type="folder">
<label>20459</label>
<path>videodb://1/9</path>
<path>videodb://movies/tags/</path>
<icon>DefaultTags.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/movies/titles.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="2" type="folder">
<label>369</label>
<path>videodb://1/2</path>
<path>videodb://movies/titles/</path>
<icon>DefaultMovieTitle.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/movies/years.xml
View file
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="3" type="folder">
<label>562</label>
<path>videodb://1/3</path>
<path>videodb://movies/years/</path>
<icon>DefaultYear.png</icon>
</node>

2 changes: 1 addition & 1 deletion system/library/video/musicvideos/albums.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="5" type="folder">
<label>132</label>
<path>videodb://3/5</path>
<path>videodb://musicvideos/albums/</path>
<icon>DefaultAlbum.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/musicvideos/artists.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="4" type="folder">
<label>133</label>
<path>videodb://3/4</path>
<path>videodb://musicvideos/artists/</path>
<icon>DefaultArtist.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/musicvideos/directors.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="6" type="folder">
<label>20348</label>
<path>videodb://3/6</path>
<path>videodb://musicvideos/directors/</path>
<icon>DefaultDirector.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/musicvideos/genres.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="1" type="folder">
<label>135</label>
<path>videodb://3/1</path>
<path>videodb://musicvideos/genres/</path>
<icon>DefaultGenre.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/musicvideos/studios.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="7" type="folder">
<label>20388</label>
<path>videodb://3/7</path>
<path>videodb://musicvideos/studios/</path>
<icon>DefaultStudios.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/musicvideos/tags.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="8" type="folder">
<label>20459</label>
<path>videodb://3/9</path>
<path>videodb://musicvideos/tags/</path>
<icon>DefaultTags.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/musicvideos/titles.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="2" type="folder">
<label>369</label>
<path>videodb://3/2</path>
<path>videodb://musicvideos/titles/</path>
<icon>DefaultMusicVideoTitle.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/musicvideos/years.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="3" type="folder">
<label>562</label>
<path>videodb://3/3</path>
<path>videodb://musicvideos/years/</path>
<icon>DefaultYear.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/recentlyaddedepisodes.xml
View file
Expand Up @@ -2,5 +2,5 @@
<node order="11" type="folder" visible="Library.HasContent(TVShows)">
<label>20387</label>
<icon>DefaultRecentlyAddedEpisodes.png</icon>
<path>videodb://5</path>
<path>videodb://recentlyaddedepisodes/</path>
</node>
2 changes: 1 addition & 1 deletion system/library/video/recentlyaddedmovies.xml
View file
Expand Up @@ -2,5 +2,5 @@
<node order="10" type="folder" visible="Library.HasContent(Movies)">
<label>20386</label>
<icon>DefaultRecentlyAddedMovies.png</icon>
<path>videodb://4</path>
<path>videodb://recentlyaddedmovies/</path>
</node>
2 changes: 1 addition & 1 deletion system/library/video/recentlyaddedmusicvideos.xml
View file
Expand Up @@ -2,5 +2,5 @@
<node order="12" type="folder" visible="Library.HasContent(MusicVideos)">
<label>20390</label>
<icon>DefaultRecentlyAddedMusicVideos.png</icon>
<path>videodb://6</path>
<path>videodb://recentlyaddedmusicvideos/</path>
</node>
2 changes: 1 addition & 1 deletion system/library/video/tvshows/actors.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="4" type="folder">
<label>344</label>
<path>videodb://2/4</path>
<path>videodb://tvshows/actors/</path>
<icon>DefaultActor.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/tvshows/genres.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="1" type="folder">
<label>135</label>
<path>videodb://2/1</path>
<path>videodb://tvshows/genres/</path>
<icon>DefaultGenre.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/tvshows/studios.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="5" type="folder">
<label>20388</label>
<path>videodb://2/5</path>
<path>videodb://tvshows/studios/</path>
<icon>DefaultStudios.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/tvshows/tags.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="6" type="folder">
<label>20459</label>
<path>videodb://2/9</path>
<icon>DefaultTags.png</icon>
<path>videodb://tvshows/tags/</path>
</node>
2 changes: 1 addition & 1 deletion system/library/video/tvshows/titles.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="2" type="folder">
<label>369</label>
<path>videodb://2/2</path>
<path>videodb://tvshows/titles/</path>
<icon>DefaultTVShowTitle.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video/tvshows/years.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="3" type="folder">
<label>562</label>
<path>videodb://2/3</path>
<path>videodb://tvshows/years/</path>
<icon>DefaultYear.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video_flat/movies.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="1" type="folder" visible="Library.HasContent(Movies)">
<label>342</label>
<path>videodb://1/2</path>
<path>videodb://movies/titles/</path>
<icon>DefaultMovies.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video_flat/musicvideos.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="3" type="folder" visible="Library.HasContent(MusicVideos)">
<label>20389</label>
<path>videodb://3/2</path>
<path>videodb://musicvideos/titles/</path>
<icon>DefaultMusicVideos.png</icon>
</node>
2 changes: 1 addition & 1 deletion system/library/video_flat/recentlyaddedepisodes.xml
View file
Expand Up @@ -2,5 +2,5 @@
<node order="11" type="folder" visible="Library.HasContent(TVShows)">
<label>20387</label>
<icon>DefaultRecentlyAddedEpisodes.png</icon>
<path>videodb://5</path>
<path>videodb://recentlyaddedepisodes/</path>
</node>
2 changes: 1 addition & 1 deletion system/library/video_flat/recentlyaddedmovies.xml
View file
Expand Up @@ -2,5 +2,5 @@
<node order="10" type="folder" visible="Library.HasContent(Movies)">
<label>20386</label>
<icon>DefaultRecentlyAddedMovies.png</icon>
<path>videodb://4</path>
<path>videodb://recentlyaddedmovies/</path>
</node>
2 changes: 1 addition & 1 deletion system/library/video_flat/recentlyaddedmusicvideos.xml
View file
Expand Up @@ -2,5 +2,5 @@
<node order="12" type="folder" visible="Library.HasContent(MusicVideos)">
<label>20390</label>
<icon>DefaultRecentlyAddedMusicVideos.png</icon>
<path>videodb://6</path>
<path>videodb://recentlyaddedmusicvideos/</path>
</node>
2 changes: 1 addition & 1 deletion system/library/video_flat/tvshows.xml
View file
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<node order="2" type="folder" visible="Library.HasContent(TVShows)">
<label>20343</label>
<path>videodb://2/2</path>
<path>videodb://tvshows/titles/</path>
<icon>DefaultTVShows.png</icon>
</node>
2 changes: 1 addition & 1 deletion xbmc/PartyModeManager.cpp
View file
Expand Up @@ -627,7 +627,7 @@ bool CPartyModeManager::AddInitialSongs(vector<pair<int,int> > &songIDs)
sqlWhereVideo[sqlWhereVideo.size() - 1] = ')'; // replace the last comma with closing bracket
CVideoDatabase database;
database.Open();
database.GetMusicVideosByWhere("videodb://3/2/", sqlWhereVideo, items);
database.GetMusicVideosByWhere("videodb://musicvideos/titles/", sqlWhereVideo, items);
}

m_history = chosenSongIDs;
Expand Down
39 changes: 16 additions & 23 deletions xbmc/dialogs/GUIDialogSmartPlaylistRule.cpp
View file
Expand Up @@ -110,16 +110,16 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()

VIDEODB_CONTENT_TYPE type = VIDEODB_CONTENT_MOVIES;
if (m_type.Equals("movies"))
basePath += "1/";
basePath += "movies/";
else if (m_type.Equals("tvshows"))
{
type = VIDEODB_CONTENT_TVSHOWS;
basePath += "2/";
basePath += "tvshows/";
}
else if (m_type.Equals("musicvideos"))
{
type = VIDEODB_CONTENT_MUSICVIDEOS;
basePath += "3/";
basePath += "musicvideos/";
}
else if (m_type.Equals("episodes"))
{
Expand All @@ -128,20 +128,20 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
type = VIDEODB_CONTENT_TVSHOWS;
else
type = VIDEODB_CONTENT_EPISODES;
basePath += "2/";
basePath += "tvshows/";
}

int iLabel = 0;
if (m_rule.m_field == FieldGenre)
{
if (m_type.Equals("tvshows") || m_type.Equals("episodes") || m_type.Equals("movies"))
videodatabase.GetGenresNav(basePath + "1/", items, type);
videodatabase.GetGenresNav(basePath + "genres/", items, type);
else if (m_type.Equals("songs") || m_type.Equals("albums") || m_type.Equals("artists") || m_type.Equals("mixed"))
database.GetGenresNav("musicdb://1/",items);
if (m_type.Equals("musicvideos") || m_type.Equals("mixed"))
{
CFileItemList items2;
videodatabase.GetGenresNav("videodb://3/1/",items2,VIDEODB_CONTENT_MUSICVIDEOS);
videodatabase.GetGenresNav("videodb://musicvideos/genres/",items2,VIDEODB_CONTENT_MUSICVIDEOS);
items.Append(items2);
}
iLabel = 515;
Expand Down Expand Up @@ -177,7 +177,7 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
}
else if (m_rule.m_field == FieldActor)
{
videodatabase.GetActorsNav(basePath + "4/",items,type);
videodatabase.GetActorsNav(basePath + "actors/",items,type);
iLabel = 20337;
}
else if (m_rule.m_field == FieldYear)
Expand All @@ -187,26 +187,19 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
if (!m_type.Equals("songs") && !m_type.Equals("albums"))
{
CFileItemList items2;
videodatabase.GetYearsNav(basePath + "3/", items2, type);
videodatabase.GetYearsNav(basePath + "years/", items2, type);
items.Append(items2);
}
iLabel = 562;
}
else if (m_rule.m_field == FieldDirector)
{
videodatabase.GetDirectorsNav(basePath + "5/", items, type);
videodatabase.GetDirectorsNav(basePath + "directors/", items, type);
iLabel = 20339;
}
else if (m_rule.m_field == FieldStudio)
{
if (m_type.Equals("movies"))
basePath += "6/";
else if (m_type.Equals("musicvideos") || m_type.Equals("mixed"))
basePath += "7/";
else
basePath += "5/";

videodatabase.GetStudiosNav(basePath, items, type);
videodatabase.GetStudiosNav(basePath + "studios/", items, type);
iLabel = 572;
}
else if (m_rule.m_field == FieldWriter)
Expand All @@ -217,7 +210,7 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
else if (m_rule.m_field == FieldTvShowTitle ||
(m_type.Equals("tvshows") && m_rule.m_field == FieldTitle))
{
videodatabase.GetTvShowsNav(basePath + "2/", items);
videodatabase.GetTvShowsNav(basePath + "titles/", items);
iLabel = 20343;
}
else if (m_rule.m_field == FieldTitle)
Expand All @@ -229,12 +222,12 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
}
else if (m_type.Equals("movies"))
{
videodatabase.GetMoviesNav(basePath + "2/", items);
videodatabase.GetMoviesNav(basePath + "titles/", items);
iLabel = 20342;
}
else if (m_type.Equals("episodes"))
{
videodatabase.GetEpisodesNav(basePath + "2/-1/-1/", items);
videodatabase.GetEpisodesNav(basePath + "titles/-1/-1/", items);
// we need to replace the db label (<season>x<episode> <title>) with the title only
CLabelFormatter format("%T", "");
for (int i = 0; i < items.Size(); i++)
Expand All @@ -243,7 +236,7 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
}
else if (m_type.Equals("musicvideos"))
{
videodatabase.GetMusicVideosNav(basePath + "2/", items);
videodatabase.GetMusicVideosNav(basePath + "titles/", items);
iLabel = 20389;
}
else
Expand Down Expand Up @@ -293,7 +286,7 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
}
else if (m_rule.m_field == FieldSet)
{
videodatabase.GetSetsNav("videodb://1/7/", items, VIDEODB_CONTENT_MOVIES);
videodatabase.GetSetsNav("videodb://movies/sets/", items, VIDEODB_CONTENT_MOVIES);
iLabel = 20434;
}
else if (m_rule.m_field == FieldTag)
Expand All @@ -306,7 +299,7 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()
else if (m_type != "movies")
return;

videodatabase.GetTagsNav(basePath + "9/", items, type);
videodatabase.GetTagsNav(basePath + "tags/", items, type);
iLabel = 20459;
}
else
Expand Down

15 comments on commit 66263ca

@alcoheca
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Montellese can you advise on a problem with video db paths in the UPnP server. this is probably down to misunderstanding on my part - we serve library://video as "Video LIbrary". Previously if I served videodb:// then no playlists or Files node was present.

Are paths such as "library://video/movies/genres.xml/" the new correct way to reference these (seems like maybe the .xml shouldn't be there)? Or should it be "videodb://movies/genres" instead? Currently I'm announcing using videodb:/// announces and fail to update the client's cache due to this.

EDIT: just to be clear, the .xml path is returned from the GetDirectory call, I'm not modifying the paths whatsoever

@Tolriq
Copy link
Contributor

@Tolriq Tolriq commented on 66263ca Apr 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (and the one on music) is a major break for a vast number of users that used those numbers.

This needs big communication.

@MartijnKaijser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed as this will most like also break skins. So we need to bump gui version
@ronie perhaps notify the skinners and time for Gotham repo?

@Montellese
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick note: There's still code in CGUIWindowVideoNav/CGUIWindowMusicNav that maps old paths like videodb://1/2/ to videodb://movies/titles/. So if a skin uses such an (old) path to open a specific view it should still work.

@alcoheca: library:// is only for custom video nodes which are controlled through the XML files and don't have anything to do directly with the videodb:// paths. Those are the paths that xbmc uses internally to reference a specific view/listing of the video/music library. Before this commit/PR these XML files just triggered a certain videodb:// path which resulted in a DB lookup which returns a list of items. Now those XML files are interpreted as smartplaylists, also result in a DB lookup (but through CSmartPlaylistDirectory and not through VIDEODATABASEDIRECTORY::CDirectoryNodeFoo) and also returns a list of items.

@alcoheca
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So my problem is due to the fact I'm using library:// paths at all? OK I can fix that pretty easily, adding in Playlists & Files node manually

@Montellese
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alcoheca: I'm not sure. You should read library://video/ for all the video nodes of an xbmc installation. That will give you paths like library://video/movies/genres.xml/ which should be browseable and give you a list of genres which in turn have paths like videodb://movies/genres/X where X is the ID of the genre.

@jmarshallnz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically this shouldn't have altered the behaviour of UPnP (or in skins) at all. In UPnP you can continue to use library://video/ to list stuff (note that XML filter nodes are IIRC referenced without the .XML extension, but you don't need to know this anyway). All that changes is instead of returning a bunch of items that have paths like videodb://1/2/1235 when you do a CDirectory::GetDirectory(), it will instead return paths like videodb://movies/titles/1235. So as long as you're aren't making assumptions about the path construct, nothing should need change.

@Tolriq
Copy link
Contributor

@Tolriq Tolriq commented on 66263ca Apr 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well path like videodb://1/2/id and such are broken from everywhere but the GUI.

If you try to find media with those path in upnp does not work anymore, or from json Files.GetDirectory is impacted also.

And I do know for sure that lot's of people use this in remotes and in scripts / plugins, so this is major change and needs communication.
The correction is not hard for people but it's better if devs are aware of that before users complains things does not work anymore and have problems to understand why.

@jmarshallnz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it even broken over UPnP - it's not clear to me.

Yes, it will be broken if you access the paths from a script or plugin or over JSON-RPC. However, I don't see why you'd need to - this is what JSON-RPC is for, to make sure you don't need to care about internal paths that might change.

It was simply overlooked that folk might be using this. We could consider adding backward compatibility for these cases perhaps, or alternatively just announce and see what demand there is for that atm.

@Tolriq
Copy link
Contributor

@Tolriq Tolriq commented on 66263ca Apr 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well doing the announce and see how much are impacted seems the minimal start.

Those urls are useful for some case for example to get the upnp stream url since there's no answer to my posts the solution is to seek Xbmc Upnp server then use a browse to this kind of urls to get the streaming url that can then be played.

Those urls are way easier and takes less resource too for offline sync than the full path for this purpose too.

And using those urls from Files.GetDirectory permit also some tricks.

I know the situation is not perfect but lots used this trick and will need to make adjustment.

For example on my dev xmbc instance AWxi web interface does use this at least 10 times (and I only have 1 plugin on this one )

@alcoheca
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPnP - announcements were broken as sending a GUIMessage UPDATE_PATH with path set to the new path ie library://movies/titles.xml/ did not match the path browsed in the client ie videodb://movies/titles/

Also I've noticed that playback from a server is also broken, but I haven't had time to track it down.

Feel free to run a couple of XBMC instances, browse one from the other and see if the error messages give you any clues

EDIT I'll have a look at this tomorrow in any case

@topfs2
Copy link
Contributor

@topfs2 topfs2 commented on 66263ca Apr 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to say, since there is a bit of negativity here. That this is an amazing change. It adds an insane amount of readability.

And I agree with jmarshall here, It sounds like we really shouldn't even be allowing these paths in Files.GetDirectory or scripts at all. the special:// paths do make sense but the db should probably be accesed in another maner.

@alcoheca
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so everyone's clear, there's no negativity coming from me! I hated the old style urls, and am 100% behind the change

@Tolriq
Copy link
Contributor

@Tolriq Tolriq commented on 66263ca Apr 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here this is not negativity this is informing that lot's of users do use those path so it needs big communication.
I don't think I say anything else :)

About removal of those, well JSON is not yet complete enough to support all database needs.
The removal of HTTP Api removed direct random queries that was cool, those permit to fills some needs like accessing actors in videolibrary for example and should really not be removed without more feedback from community and provide alternatives to users needs.

@alcoheca
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the broken playback was due to an ID-10T error, three cheers for new beginnings..

Please sign in to comment.