Skip to content

Commit

Permalink
Fix loader skipping music files that are in library but located on a …
Browse files Browse the repository at this point in the history
…server hence have dynpath starting "HTTP" and IsInternetStream returns true.
  • Loading branch information
DaveTBlake committed Apr 6, 2019
1 parent 4eb34eb commit 6b261b7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion xbmc/guilib/guiinfo/MusicGUIInfo.cpp
Expand Up @@ -49,7 +49,7 @@ bool CMusicGUIInfo::InitCurrentItem(CFileItem *item)
tag->SetLoaded(true);

// find a thumb for this file.
if (item->IsInternetStream())
if (item->IsInternetStream() && !item->IsMusicDb())
{
if (!g_application.m_strPlayListFile.empty())
{
Expand Down
4 changes: 2 additions & 2 deletions xbmc/music/MusicInfoLoader.cpp
Expand Up @@ -150,7 +150,7 @@ bool CMusicInfoLoader::LoadItemCached(CFileItem* pItem)
pItem->IsPlayList() || pItem->IsSmartPlayList() ||
StringUtils::StartsWithNoCase(pItem->GetPath(), "newplaylist://") ||
StringUtils::StartsWithNoCase(pItem->GetPath(), "newsmartplaylist://") ||
pItem->IsNFO() || pItem->IsInternetStream())
pItem->IsNFO() || (pItem->IsInternetStream() && !pItem->IsMusicDb()))
return false;

// Get thumb for item
Expand All @@ -168,7 +168,7 @@ bool CMusicInfoLoader::LoadItemLookup(CFileItem* pItem)
pItem->IsPlayList() || pItem->IsSmartPlayList() ||
StringUtils::StartsWithNoCase(pItem->GetPath(), "newplaylist://") ||
StringUtils::StartsWithNoCase(pItem->GetPath(), "newsmartplaylist://") ||
pItem->IsNFO() || pItem->IsInternetStream())
pItem->IsNFO() || (pItem->IsInternetStream() && !pItem->IsMusicDb()))
return false;

if (!pItem->HasMusicInfoTag() || !pItem->GetMusicInfoTag()->Loaded())
Expand Down
2 changes: 1 addition & 1 deletion xbmc/music/windows/GUIWindowMusicBase.cpp
Expand Up @@ -476,7 +476,7 @@ void CGUIWindowMusicBase::AddItemToPlayList(const CFileItemPtr &pItem, CFileItem
return;
}
}
else if(pItem->IsInternetStream())
else if(pItem->IsInternetStream() && !pItem->IsMusicDb())
{ // just queue the internet stream, it will be expanded on play
queuedItems.Add(pItem);
}
Expand Down

0 comments on commit 6b261b7

Please sign in to comment.