Skip to content

Commit

Permalink
[metadata.themoviedb.org] youtube dep is now optional (version 2.0.2)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mkortstiege
mkortstiege committed Jan 15, 2012
1 parent ef79fe7 commit 7e91ec7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions addons/metadata.themoviedb.org/addon.xml
View file
@@ -1,14 +1,14 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="metadata.themoviedb.org"
name="The MovieDB"
version="2.0.1"
version="2.0.2"
provider-name="Team XBMC">
<requires>
<import addon="xbmc.metadata" version="1.0"/>
<import addon="metadata.common.themoviedb.org" version="2.0.0"/>
<import addon="metadata.common.hdtrailers.net" version="1.0.6"/>
<import addon="metadata.common.imdb.com" version="2.1.3"/>
<import addon="plugin.video.youtube" version="2.1.0"/>
<import addon="plugin.video.youtube" version="2.1.0" optional="true"/>
</requires>
<extension point="xbmc.metadata.scraper.movies"
language="en"
Expand Down
3 changes: 3 additions & 0 deletions addons/metadata.themoviedb.org/changelog.txt
View file
@@ -1,3 +1,6 @@
[B]2.0.2[/B]
- changed: made the youtube addon (trailers) an optional dependency

[B]2.0.1[/B]
- fixed: imdb url nfo not resolving tmdb id

Expand Down
2 changes: 1 addition & 1 deletion addons/metadata.themoviedb.org/resources/settings.xml
View file
Expand Up @@ -2,7 +2,7 @@
<settings>
<setting label="30005" type="bool" id="keeporiginaltitle" default="false"/>
<setting label="30000" type="bool" id="fanart" default="true"/>
<setting label="30004" type="bool" id="trailer" default="true"/>
<setting label="30004" type="bool" id="trailer" default="true" enable="System.HasAddon(plugin.video.youtube)"/>
<setting label="30001" type="labelenum" values="No|480p|720p|1080p" id="TrailerQ" default="No"/>
<setting label="30002" type="labelenum" values="da|fi|nl|de|it|es|fr|pl|hu|el|tr|ru|he|ja|pt|zh|cs|sl|hr|ko|en|sv|no" id="language" default="en"/>
<setting label="30003" type="bool" id="imdbrating" default="false"/>
Expand Down

6 comments on commit 7e91ec7

@MartijnKaijser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition :)
Was already wondering how that optional would work.
Wouldn't it also be better to also disable/hide id="TrailerQ" when id="trailer" is disabled or am I reading it wrong?
Also English string could better be made: 'Preferred Trailer Quality from HD-Trailers.net'

@mkortstiege
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hd-trailers.net stuff is handled differently but yea, we should most likely change the wording. Not sure if it's going to happen now as it would require all translators to come up with a new one.

@MartijnKaijser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable. Although is just a different word phrasing which wouldn't harm if not translated and maybe has to be made sooner than later in case translations will be update.

@queeup
Copy link
Contributor

@queeup queeup commented on 7e91ec7 Jan 15, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it already added this to *.xsd files? Or let me ask like that is there any xsd file for settings.xml?

@Memphiz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for reminding ... wanted to look through the wiki where i have to add those

@mkortstiege
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartijnKaijser: Mind sending a pull for the wording? I'd like to have some input from the others on this.

Please sign in to comment.