Skip to content

Commit

Permalink
pvr: avoid closing stream players on channel switch
Browse files Browse the repository at this point in the history
  • Loading branch information
@FernetMenta
FernetMenta committed Sep 10, 2014
1 parent 399275a commit 8c7f6eb
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion xbmc/cores/dvdplayer/DVDPlayer.cpp
View file
Expand Up @@ -1323,7 +1323,11 @@ void CDVDPlayer::Process()
break;
}

OpenDefaultStreams();
// on channel switch we don't want to close stream players at this
// time. we'll get the stream change event later
if (!m_pInputStream->IsStreamType(DVDSTREAM_TYPE_PVRMANAGER) ||
!m_SelectionStreams.m_Streams.empty())
OpenDefaultStreams();

// never allow first frames after open to be skipped
if( m_dvdPlayerVideo->IsInited() )
Expand Down

2 comments on commit 8c7f6eb

@elupus
Copy link
Contributor

@elupus elupus commented on 8c7f6eb Nov 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this into OpenDefaultStreams()? Also, do we even need to check for PVRMANAGER? If we have no streams at all, we probably don't want to close players then either. We possibly want to send EOF message instead.

@FernetMenta
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when changing channels we stay without any streams for a while. sending EOF in this case would terminate playback.

Please sign in to comment.