Skip to content

Commit

Permalink
Move the reset code for finished event into ui thread.
Browse files Browse the repository at this point in the history
when we are using bluetooth keyboard, there is chance the doDeactivate
method be called before the finished event reset in xbmc thread.
  • Loading branch information
ulion committed Feb 21, 2013
1 parent 7bee27d commit 983f006
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions xbmc/osx/ios/IOSKeyboardView.mm
Expand Up @@ -176,6 +176,7 @@ - (void) doActivate:(NSDictionary *)dict
[g_xbmcController activateKeyboard:self];
[_textField becomeFirstResponder];
[self setNeedsLayout];
keyboardFinishedEvent.Reset();
}

- (void)activate
Expand All @@ -191,8 +192,6 @@ - (void)activate
return;
}

keyboardFinishedEvent.Reset();

// emulate a modale dialog here
// we are waiting on the user finishing the keyboard
// and have to process our app while doing that
Expand Down

2 comments on commit 983f006

@Memphiz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulion - there is a problem when using the official xbmc remote app connected to XBMC running on a different ios device. Once the native keyboard is up on the xbmc instance there is no way to 1. close the keyboard, 2. enter anything via the remote app.

Any idea on how we could solve this?

@ulion
Copy link
Contributor Author

@ulion ulion commented on 983f006 Feb 2, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.