Skip to content

Commit

Permalink
dvdplayer: drop setting sync methods for sync playback to display. de…
Browse files Browse the repository at this point in the history
…fault to resample and drop/dup for passthrough
  • Loading branch information
FernetMenta committed Dec 28, 2014
1 parent 9d4644e commit df1c1b8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 43 deletions.
28 changes: 2 additions & 26 deletions language/English/strings.po
Expand Up @@ -6339,27 +6339,7 @@ msgctxt "#13459"
msgid "Use OMXPlayer for decoding of video files."
msgstr ""

#empty strings from id 13460 to 13499

#: system/settings/settings.xml
msgctxt "#13500"
msgid "A/V sync method"
msgstr ""

#: system/settings/settings.xml
msgctxt "#13501"
msgid "Audio clock"
msgstr ""

#: system/settings/settings.xml
msgctxt "#13502"
msgid "Video clock (Drop/Dupe audio)"
msgstr ""

#: system/settings/settings.xml
msgctxt "#13503"
msgid "Video clock (Resample audio)"
msgstr ""
#empty strings from id 13460 to 13503

#: system/settings/settings.xml
msgctxt "#13504"
Expand Down Expand Up @@ -14115,11 +14095,7 @@ msgctxt "#36166"
msgid "Synchronise the video to the refresh rate of the monitor."
msgstr ""

#. Description of setting "Videos -> Playback -> A/V sync method" with label #13500
#: system/settings/settings.xml
msgctxt "#36167"
msgid "Audio has to stay in sync, this can either be done by resampling, skipping/duplicating packets, or adjusting the clock if it gets out of sync too far."
msgstr ""
#empty string with id 36167

#. Description of setting "Videos -> Playback -> Maximum speedup/slowdown amount (%)" with label #13504
#: system/settings/settings.xml
Expand Down
16 changes: 0 additions & 16 deletions system/settings/settings.xml
Expand Up @@ -428,21 +428,6 @@
<default>false</default>
<control type="toggle" />
</setting>
<setting id="videoplayer.synctype" type="integer" parent="videoplayer.usedisplayasclock" label="13500" help="36167">

This comment has been minimized.

Copy link
@Montellese

Montellese Mar 5, 2015

Member

You missed win32.xml and xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAEResamplePi.cpp.

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Mar 5, 2015

Author Contributor

oops. I will correct when back home. thanks

This comment has been minimized.

Copy link
@Montellese

Montellese Mar 5, 2015

Member

I'm already on it.

<level>2</level>
<default>2</default> <!-- SYNC_RESAMPLE -->
<constraints>
<options>
<option label="13501">0</option> <!-- SYNC_DISCON -->
<option label="13502">1</option> <!-- SYNC_SKIPDUP -->
<option label="13503">2</option> <!-- SYNC_RESAMPLE -->
</options>
</constraints>
<dependencies>
<dependency type="enable" setting="videoplayer.usedisplayasclock" operator="is">true</dependency>
</dependencies>
<control type="spinner" format="string" />
</setting>
<setting id="videoplayer.maxspeedadjust" type="number" label="13504" help="36168">
<level>4</level>
<default>5.0</default>
Expand All @@ -455,7 +440,6 @@
<dependency type="enable">
<and>
<condition setting="videoplayer.usedisplayasclock" operator="is">true</condition>
<condition setting="videoplayer.synctype" operator="is">2</condition> <!-- SYNC_RESAMPLE -->
</and>
</dependency>
</dependencies>
Expand Down
2 changes: 1 addition & 1 deletion xbmc/cores/dvdplayer/DVDPlayerAudio.cpp
Expand Up @@ -186,7 +186,7 @@ void CDVDPlayerAudio::OpenStream( CDVDStreamInfo &hints, CDVDAudioCodec* codec )
m_synctype = SYNC_DISCON;
m_setsynctype = SYNC_DISCON;
if (CSettings::Get().GetBool("videoplayer.usedisplayasclock"))
m_setsynctype = CSettings::Get().GetInt("videoplayer.synctype");
m_setsynctype = SYNC_RESAMPLE;
m_prevsynctype = -1;

m_error = 0;
Expand Down

0 comments on commit df1c1b8

Please sign in to comment.