Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

fixed: AE suspending was broken resulting in it resuming/suspending o…

…ver and over again (fixes ticket #13508)
  • Loading branch information...
commit e0a9d07e18d2578702e3ed158e006d3544d2a232 1 parent fbf1f62
arnova authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  xbmc/cores/AudioEngine/Engines/SoftAE/SoftAE.cpp
View
2  xbmc/cores/AudioEngine/Engines/SoftAE/SoftAE.cpp
@@ -1041,7 +1041,7 @@ void CSoftAE::Run()
delete m_sink;
m_sink = NULL;
}
- if (!m_playingStreams.empty() || !m_playing_sounds.empty() || m_sounds.empty())
+ if (!m_playingStreams.empty() || !m_playing_sounds.empty() || !m_sounds.empty())
m_softSuspend = false;
m_wake.WaitMSec(SOFTAE_IDLE_WAIT_MSEC);
}

4 comments on commit e0a9d07

@Memphiz
Owner

thx

@theuni
Owner

This is not correct, this will cause early break-outs as well.

As far as I can tell, m_sounds is just a list of sounds cached for playback, that has nothing to do with the sleep status.

As an example, the startup sound may be loaded for a window, but if we're not currently playing it, it shouldn't block sleeping.

Removing the m_sounds check altogether fixes my looping alsa, I believe that's the correct thing to do.

I have a few other Alsa initialization fixes as well, PR is coming up.

@gnif
Collaborator

@theuni - You are correct, m_sounds is indeed just a list of the available sounds, this should not be part of the condition.

@DDDamian

@gnif - think you checked a bit of an old one :) try #2061

Please sign in to comment.
Something went wrong with that request. Please try again.