Skip to content

Commit

Permalink
[database] use IF EXISTS on DROP TABLE if we're not completely sure t…
Browse files Browse the repository at this point in the history
…he table exists
  • Loading branch information
Jonathan Marshall committed Feb 5, 2014
1 parent a809ff0 commit ef583de
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions xbmc/TextureDatabase.cpp
Expand Up @@ -214,12 +214,12 @@ void CTextureDatabase::UpdateTables(int version)
}
if (version < 9)
{ // get rid of the old path table and add the type column
m_pDS->exec("DROP TABLE path");
m_pDS->exec("DROP TABLE IF EXISTS path");
m_pDS->exec("CREATE TABLE path (id integer primary key, urlhash integer, url text, type text, texture text)\n");
}
if (version < 10)
{ // get rid of urlhash in both tables...
m_pDS->exec("DROP TABLE path");
m_pDS->exec("DROP TABLE IF EXISTS path");
m_pDS->exec("CREATE TABLE path (id integer primary key, url text, type text, texture text)\n");

m_pDS->exec("CREATE TEMPORARY TABLE texture_backup(id,url,cachedurl,usecount,lastusetime,imagehash,lasthashcheck)");
Expand All @@ -235,7 +235,7 @@ void CTextureDatabase::UpdateTables(int version)
}
if (version < 12)
{ // create new sizes table and move usecount info to it.
m_pDS->exec("DROP TABLE texture");
m_pDS->exec("DROP TABLE IF EXISTS texture");
m_pDS->exec("CREATE TABLE texture (id integer primary key, url text, cachedurl text, imagehash text, lasthashcheck text)");
m_pDS->exec("CREATE TABLE sizes (idtexture integer, size integer, width integer, height integer, usecount integer, lastusetime text)");
}
Expand Down
2 changes: 1 addition & 1 deletion xbmc/music/MusicDatabase.cpp
Expand Up @@ -3830,7 +3830,7 @@ void CMusicDatabase::UpdateTables(int version)

if (version < 27)
{
m_pDS->exec("DROP TABLE thumb");
m_pDS->exec("DROP TABLE IF EXISTS thumb");

CMediaSettings::Get().SetMusicNeedsUpdate(27);
CSettings::Get().Save();
Expand Down

0 comments on commit ef583de

Please sign in to comment.