Missing text when sorting from inside addon

[bigretromike]

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:
There is missing variables/text for year/rating in default skin when sorting content inside addon that have setContent(tvshows) and isFolder=True;
Currently this is omitted for addons, and show incorrect data: for rating showing year, and for year showing nothing.

Expected Behavior

Here is a clear and concise description of what was expected to happen:
Year/Rating should be visable to content that is created by addon.

Actual Behavior

For Rating there is a Year, and for Year there is a date shown in place of proper data.

Possible Fix

#14504 this was propose by me but @ronie suggested to fix it in core.

To Reproduce

Steps to reproduce the behavior:
#14504 (comment)
Here is a live demo

Debuglog

The debuglog can be found here:
#14504

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

• Android

• iOS

• Linux

• OSX

• Raspberri-Pi

• Windows

• Windows UWP

• Operating system version/name:

• Kodi version: 17.6

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

[razzeee]

Rating seems to work fine for me with your addon

But year has a date and date is empty/has nothing

Edit: Date seems to be date added that's why it's empty

[bigretromike]

those are files. not folder.
Files work fine, Folders are broken.
Also @ronie confirm this as bug

You missed the part that I wrote isFolder=True, but I don't mind.

Episode are shown correct, that does not are series/tvshows. You have to comment one line and uncomment one below to test that.

change:
# build_groups_menu()
build_serie_episodes()

to this:
build_groups_menu()
# build_serie_episodes()

And thank you for coming here, and checking this out.

[razzeee]

But we're talking about the different sort by options and the data shown here in the section in the middle?

[ronie]

the problem is that ListItem.Label2 returns empty for folder items.

[bigretromike]

Sorting works correct, it does sort by value but omit showing it:
by TITLE (both are correct)

by YEAR (for episode its blank, for folder its DATE not YEAR)

by RATING (for episodes is correct, for folder is MISSING)

by DATE (for both DATE is missing, but date is there - seen in YEAR sorting)

[bigretromike]

the problem is that ListItem.Label2 returns empty for folder items.

It's a wider issue.
Its for both folders and non-folder (see the compare), but folder is the most broken right now.

[razzeee]

Don't confuse Date and Year. Year is the year when the media was released. Date is the date you added it to your library.

[bigretromike]

Im not confusing it. If I recall those are similar dates with my examples.
One is year and other is date.
No matter what they represents, they are both populated - and not display correctly, as you see yourself.

[bigretromike]

@ronie any updates on this issue, maybe it will be fixed in Leia ?

[bigretromike]

I tested Leia, and the issue is still there.
Could someone response to this? @MartijnKaijser @DaVukovic @pkerling @phate89
Sorry if I marked wrong people, but this issue is ongoing and still present, and probably dig below anyone eyes.

[bigretromike]

Ok, my PR #16433 have been merge, this issue was resolved with that PR.
18.4 and 19.0 shouldn't be affected anymore.
Thanks guys for the time.