New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kodi 18b4 JSONRPC thumbnail requests failing #14726
Comments
@kbirger are the thumbnails showing correctly for you within kodi? |
@kbirger please provide a debug log even if you can not see anything relevent in it. @lobermann I expect that thumbnails in GUI are fine (but good to be sure). This is possibly caused by the security fix made by #14501, and the location of the image files being somewhere that API requests are no longer permitted to access. |
@DaveTBlake ok, sounds plausibel. I was also thinking of #14586 that is in the codepath of loading thumbnails. |
@lobermann - yes, they are I was able to get around the issue by creating a source in Kodi which encompasses my entire device. In this case, the share is just on /storage, which I am aware is probably a terrible practice. Even so, it seems like #14501 isn't designed to be causing this sort of effect, right? I can try to provide logs again later if anyone still thinks they will be helpful (in light of my comment/workaround above). Please let me know specifically what log settings you'd like me to use. |
@kbirger are you able to test a build of the fix in PR14758? Available on the mirrors |
I'll check it out this evening (EST) |
Hi,
Thank you for the fix and apologies for the delay. I was away. I confirmed
on Kore and on Chorus2. Seems good!
…On Sun, Nov 4, 2018, 3:06 AM Dave Blake ***@***.*** wrote:
@kbirger <https://github.com/kbirger> #14758
<#14758> and another related fix #14783
<#14783> (access art embedded in media
files and artists info folder) are both in the v18 Beta 5 release. I think
that will resolve this issue, but will wait for your feedback before
closing it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14726 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKHC61aXJDeMelfiDNJr21I0EdB23KMks5urqAQgaJpZM4X9eTy>
.
|
Expected Behavior
As before, I expect applications such as Chorus2 and Kore to be able to load thumbnails from videos in my Kodi library. This worked up until 18b4. I had no problems with 18b3, but did not try any nightlies in between.
Actual Behavior
Chorus2 and Kore do not load thumbnails anymore. Gray empty boxes show up. Chorus2 reports 404s in my browser. I can't imagine this would be an intentional change as it breaks support for an "Official" application.
To Reproduce
Steps to reproduce the behavior:
Debuglog
Still working on this. I wasn't able to see anything in my logs that was relevant. I tried enabling logging as well as component specific logging for JSONRPC and WebServer, then reloaded Chorus2 with browser caching disabled. Please advise on helpful steps to get logs which might be useful.
Your Environment
Used Operating system:
[ X] Android (Nvidia Shield)
iOS
Linux
OSX
Raspberri-Pi
Windows
Windows UWP
Operating system version/name:
Kodi version: 18b4
The text was updated successfully, but these errors were encountered: