Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodi 18b4 JSONRPC thumbnail requests failing #14726

Closed
6 tasks
kbirger opened this issue Oct 27, 2018 · 9 comments
Closed
6 tasks

Kodi 18b4 JSONRPC thumbnail requests failing #14726

kbirger opened this issue Oct 27, 2018 · 9 comments
Labels
Resolution: Fixed issue was resolved by a code change v18 Leia
Milestone

Comments

@kbirger
Copy link

kbirger commented Oct 27, 2018

Expected Behavior

As before, I expect applications such as Chorus2 and Kore to be able to load thumbnails from videos in my Kodi library. This worked up until 18b4. I had no problems with 18b3, but did not try any nightlies in between.

Actual Behavior

Chorus2 and Kore do not load thumbnails anymore. Gray empty boxes show up. Chorus2 reports 404s in my browser. I can't imagine this would be an intentional change as it breaks support for an "Official" application.

To Reproduce

Steps to reproduce the behavior:

  1. Set up Kodi with Webserver and Chorus2 as web UI
  2. Load up Chorus2
  3. Click on Movies or TV Shows
  4. Observe beautiful gray boxes where thumbnails used to be

Debuglog

Still working on this. I wasn't able to see anything in my logs that was relevant. I tried enabling logging as well as component specific logging for JSONRPC and WebServer, then reloaded Chorus2 with browser caching disabled. Please advise on helpful steps to get logs which might be useful.

Your Environment

Used Operating system:

  • [ X] Android (Nvidia Shield)

  • iOS

  • Linux

  • OSX

  • Raspberri-Pi

  • Windows

  • Windows UWP

  • Operating system version/name:

  • Kodi version: 18b4

@lobermann
Copy link
Member

@kbirger are the thumbnails showing correctly for you within kodi?

@DaveTBlake
Copy link
Member

@kbirger please provide a debug log even if you can not see anything relevent in it.
Where are the media sources and images located?

@lobermann I expect that thumbnails in GUI are fine (but good to be sure). This is possibly caused by the security fix made by #14501, and the location of the image files being somewhere that API requests are no longer permitted to access.

@lobermann
Copy link
Member

@DaveTBlake ok, sounds plausibel. I was also thinking of #14586 that is in the codepath of loading thumbnails.

@kbirger
Copy link
Author

kbirger commented Oct 28, 2018

@lobermann - yes, they are
@DaveTBlake - I think you're right about PR #14501

I was able to get around the issue by creating a source in Kodi which encompasses my entire device. In this case, the share is just on /storage, which I am aware is probably a terrible practice. Even so, it seems like #14501 isn't designed to be causing this sort of effect, right?

I can try to provide logs again later if anyone still thinks they will be helpful (in light of my comment/workaround above). Please let me know specifically what log settings you'd like me to use.

@DaveTBlake
Copy link
Member

@kbirger no this side effect of #14501 was not intentional, and @wsnipex is pursing a solution. Logs not necessary at this stage thanks

@DaveTBlake
Copy link
Member

@kbirger are you able to test a build of the fix in PR14758? Available on the mirrors
http://mirrors.kodi.tv/test-builds/android as kodi-20181101-bb93798c-PR14758 etc.

@kbirger
Copy link
Author

kbirger commented Nov 2, 2018

I'll check it out this evening (EST)

@DaveTBlake
Copy link
Member

@kbirger #14758 and another related fix #14783 (access art embedded in media files and artists info folder) are both in the v18 Beta 5 release. I think that will resolve this issue, but will wait for your feedback before closing it.

@kbirger
Copy link
Author

kbirger commented Nov 11, 2018 via email

@DaveTBlake DaveTBlake added the Resolution: Fixed issue was resolved by a code change label Nov 12, 2018
@yol yol added this to the Leia 18.0-rc1 milestone Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Fixed issue was resolved by a code change v18 Leia
Projects
None yet
Development

No branches or pull requests

5 participants